From nobody Fri Feb 10 10:05:07 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PCq9H6m1kz3pgFZ for ; Fri, 10 Feb 2023 10:05:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PCq9H5kTmz3jpG for ; Fri, 10 Feb 2023 10:05:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676023507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jVeQbAfICRhWsTBTnrU9aGSoeCXARcf3LR/cRFrR3Kc=; b=YlI7IGQL7Cvq22y6zt6nFl98cmuPWyDHh8LJpxydtxEW0RC5b20YiO6oIRyNjFYK6maN27 o+sq16D4q/sOt+Wume6S9D3bAgiXbAqFW5tIYA5iUtIA9hw1uu7HDXyvxy7Yi6K4IH8feB b1Hs7lCHdLf1CQ4Grh9lSUEQeEjvZ1R9wnUtcZoKNpmKX/7TSpHW3OTl5XzGXyWo0n7x1o 2W8q0nklQmDxoKzwaWQZFl5S6bsor2hQ4pbC8BZvNWbM+evqxuXAaKKcNeojappvj4nFGX p/6yd033r2NDNeGRD30qznWzyo7q/Pqyt49dnNYh4HkUBG0AXYIUdjsNyb/Dig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676023507; a=rsa-sha256; cv=none; b=p8IHfiW8IKrl94o4UhWb975ApxgzFTEOAkBBO0EojFdgALsyd9xmH/bv/01iyHj6LOT6zc /ghf5/xTCxJSZEb7/UC+PftWLSqIIEhJyd5lSIkpsdnG63tntPzs1aBjc3DThtwojHnpKh ML+3z6N65z0CJgLSX2sZ4/i6o1cl+llzt141CnUijLSv9o6TBTtbvVE6hFhc9QOI3vcs+O 7vBFwNeAlvnPmV5mPQxxCNac0fui8aA9go/ol9mHV2kDN8ddtCQXMQjDBKnFOjdGQbS1/N YHsxKlBuUtvTz/slHU9d7nMnH12Mr9soufSvpyBD2gr6FFhLDJsWrYprdZsHtw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PCq9H4j7SzDhX for ; Fri, 10 Feb 2023 10:05:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 31AA57Or084618 for ; Fri, 10 Feb 2023 10:05:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 31AA57TP084617 for net@FreeBSD.org; Fri, 10 Feb 2023 10:05:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268246] crash and panic using pfsync on 13.1-RELEASE Date: Fri, 10 Feb 2023 10:05:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268246 --- Comment #70 from Kristof Provost --- (In reply to jjasen from comment #68) Okay, excellent. I think we've figured out what's going on here. I also think I see why I can't reproduce it yet. It's interpreting the IPv6 header as an IPv4 header (and we didn't notice so far, because the ip_fragment() code overwrites the version field in the header), and it's reading the flow label as length. We're defaulting to a flow label of 0, and that's putting us in a code path that avoids ip_fragment(). (The "If small enough for interface" case in ip_output()) I'm having an argument with some of the test tools to try to get a flow lab= el set so I can make it panic locally. It should be relatively straightforward to fix this, but I'm going to be on poor connectivity for a few days, so it won't be for tomorrow. The pfsync_defer_tmo fix is in stable/13 and will be part of 13.2, but it's= not in releng/13.1 (and never will be). --=20 You are receiving this mail because: You are the assignee for the bug.=