From nobody Wed Feb 08 06:08:06 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PBV0k5hr5z3klZt for ; Wed, 8 Feb 2023 06:08:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PBV0k3mmpz3F8s for ; Wed, 8 Feb 2023 06:08:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675836486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tVZjMIuC8YeLhik3SwQm4ZKTe00M0rIp8yMD6pcIP3U=; b=ESvw4SVYyY2PhCYnJ8De4mSr20pvGTsvDX4zPuiuGbGrZicT/N4OBW8EYm2taDsb9Q1eoo hBzCftN2e1l88rTlHnnNdlnqIQ1iYQkoBwTK+bVn/qoD9adiSOmxGiIh2JSMXOp5CyUv36 /4Bk67zoOOF5gtABxQx+R6SUJGldEsV2v76uay1qFJtZg3zsb+SXblfma6es2Jv2+OAycD JqDq3tkJy1xkq87jxYTdiNFIOpOLdCo9W2kSkmSDo9fy1E9w1V6wtzV5qcx1KFcdVlQr/C 2AAahwABYuHwSSRBMk+7+b/uhZmZwQb5fxP6H070vOeOnhXF9gew+2c9+P0Ujw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675836486; a=rsa-sha256; cv=none; b=mmGIh86sb8PnxL1SJS64FbpWk5XztnMdiXjqXKrI9WJUIGidv9wvwEAWGz0/bkQ6locvQf FwkhEo1GFNlCZJxWdM508qYm7EH1I/tJ5fYOIi+a4JKFrVKWYlCNDQJIl9u5Auj3U0nKxf Z1h/pP5vh09kqcNdni+Iww2HUDHxpFBOGzJCzxjaDNOIj0f3POhPBAVpbJZ0QOyE/HspmR zIzpA0az92jqE/7z5DjT9TD2k3Yc79enqCrp9Ea7+0qdpkT0BA/VDsVNqB5f5PQQCpQiCa nR+vo/dWF+Qo2RjJtY6oQFulw64bjXB7Adpk9L++7gWRTdYVgpx659dnfvxJZQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PBV0k2qnJzmS6 for ; Wed, 8 Feb 2023 06:08:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 318686l5056765 for ; Wed, 8 Feb 2023 06:08:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 318686vL056764 for net@FreeBSD.org; Wed, 8 Feb 2023 06:08:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268246] crash and panic using pfsync on 13.1-RELEASE Date: Wed, 08 Feb 2023 06:08:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268246 --- Comment #67 from Kristof Provost --- That destination address is a bit odd... Do you have IPv6 traffic? pfsync always uses ip_output() for deferred traffic, which might perhaps explain t= he panic if we're shoving IPv6 packets through that. So let's try to skip IPv6 for now:=20 diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 47c3217f399c..a9e6988ff7af 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -2345,6 +2345,15 @@ pfsyncintr(void *arg) n =3D m->m_nextpkt; m->m_nextpkt =3D NULL; + { + struct ip *ip =3D mtod(m, struct ip *); + if (ip->ip_v !=3D IPVERSION) { + printf("%s() skipping !IPv4 traffic= \n", __func__); + m_freem(m); + continue; + } + } + /* * We distinguish between a deferral packet and our * own pfsync packet based on M_SKIP_FIREWALL Obviously that's not a fix, but if that stops the panic at least we'll know= and we can work on a real fix later. --=20 You are receiving this mail because: You are the assignee for the bug.=