[Bug 254596] if_bridge wants LRO turned off, if_vlan insists it remain on

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254596

--- Comment #14 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=5f11a33ceeb385477cb22d9ad5941061c5a26be9

commit 5f11a33ceeb385477cb22d9ad5941061c5a26be9
Author:     Paul Vixie <paul@redbarn.org>
AuthorDate: 2023-08-11 18:17:16 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2023-08-11 22:50:37 +0000

    if_vlan: do not enable LRO for bridge interaces

    If the parent interface is not a bridge and can do LRO and
    checksum offloading on VLANs, then guess it may do LRO on VLANs.
    False positive here cost nothing, while false negative may lead
    to some confusions. According to Wikipedia:

    "LRO should not operate on machines acting as routers, as it breaks
    the end-to-end principle and can significantly impact performance."

    The same reasoning applies to machines acting as bridges.

    PR:             254596
    MFC after:      3 weeks

 sys/net/if_vlan.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.