Re: in_pcbbind_setup: wrong condition regarding INP_REUSEPORT ?

From: Sean Bruno <sbruno_at_freebsd.org>
Date: Tue, 04 Oct 2022 11:37:56 UTC

On 10/3/22 04:14, Andriy Gapon wrote:
> 
> I must admit that the condition in question is fairly long and 
> non-trivial and I cannot decipher it, but these two lines look wrong to me:
> 
>                                       (t->inp_flags2 & INP_REUSEPORT) ||
>                                       (t->inp_flags2 & INP_REUSEPORT_LB) 
> == 0) &&
> 
> I'd expect that the check would be symmetric with respect to 
> INP_REUSEPORT and INP_REUSEPORT_LB.
> The problem seems to come from 1a43cff92a20d / r334719 / D11003.
> 

I think you are pointing at this absurd conditional?

https://cgit.freebsd.org/src/tree/sys/netinet/in_pcb.c#n1049

Besides the twisted logic, what problem are you trying to solve?

sean