From nobody Fri May 20 00:43:23 2022 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1FFE01B47452 for ; Fri, 20 May 2022 00:43:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L47Hv6ppQz3ssR for ; Fri, 20 May 2022 00:43:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CA07C27CC7 for ; Fri, 20 May 2022 00:43:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24K0hNRs050732 for ; Fri, 20 May 2022 00:43:23 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24K0hNkn050731 for net@FreeBSD.org; Fri, 20 May 2022 00:43:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 263379] [regression] [ipsec] compatibility broken between stable/12 and stable/13 opencrypto in AEAD mode Date: Fri, 20 May 2022 00:43:23 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jhb@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653007404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WHoRXDRVm5B2SKPUoZ7XeFwDmC3O6e7wyXtuIblHiFA=; b=hpGn/PnborQPjyJUqR4GQ2vxrFVf7uELkQAZ74BTebvl/JNQA7NhLS49YazG28QWwFyETB DhguEQlkzw6xeZ71wqBeSr+lz0o1qp7iyjQhcQngDHNGyb8peSDUR1tl/zMUgvJNIQM0Vt aPP8oo+CeKlE5AWmmD01tdNLRJbOC9sc0EGAJ7p7uTCrDio1W9n0k+H7PD42g5Vxg1Pbgi orpIN0JdyDAtab1y0v6tU84ecU85gL4Kzy9Ess0kkPazijmFF94wTgTQxicB9yRpjtkauU q1t66Iw3U/kXAJ7ioYCEUCaYTvL0i+jFmGuS2Qp5M8ut+UWoBTBJ3dvC9WNdgQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653007404; a=rsa-sha256; cv=none; b=SG3zEI9Zw1h2gzWlYLQH+p3fXplSn4JqzVl3695kGO/ybTjDnntJK6Pc4d+O6Apvp9/xwt R0vky0Qchyq6o6dsSdNc+K2Hv0d4kjrhkKBgGp2UaBu2iV5MFHw0BpbptcvhsXtiHsMVUw x9yxRXS6jduA2rqqKXKdI+JfDHtaJ7s30kRDSRV5PhXzua4oxhCDqOyRjoVFPg5OqQu9My F+QR1YFcKSJ3MJWppazHzST5Dl8YB3GYuGt056m/kfMAn6X48+GMv11y6YzZuKoHuuBSDZ kVz2kg4CN+CQFW7JCJFPwodHVYrWFuYnJu4UL8w6IFf8s8i1Hb0wgX3YFUwJWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263379 --- Comment #17 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D6aaf8a8b1bcf500aa7342043d43007ff9= c52cd65 commit 6aaf8a8b1bcf500aa7342043d43007ff9c52cd65 Author: John Baldwin AuthorDate: 2022-04-27 19:18:52 +0000 Commit: John Baldwin CommitDate: 2022-05-20 00:42:24 +0000 setkey(8): Clarify language around AEAD ciphers. AEAD ciphers for IPsec combine both encryption and authentication. As such, ESP configurations using an AEAD cipher should not use a seperate authentication algorithm via -A. However, this was not apparent from the setkey manpage and 12.x and earlier did not perform sufficient argument validation permitting users to pair an explicit -A such as SHA256-HMAC with AES-GCM. (The result was a non-standard combination of AES-CTR with the specified MAC, but with the wrong initial block counter (and thus different keystream) compared to using AES-CTR as the cipher.) Attempt to clarify this in the manpage by explicitly calling out AEAD ciphers (currently only AES-GCM) and noting that AEAD ciphers should not use -A. While here, explicitly note which authentication algorithms can be used with esp vs esp-old. Also add subsection headings for the different algorithm lists and tidy some language. I did not convert the tables to column lists (Bl -column) though that would probably be more correct than using literal blocks (Bd -literal). PR: 263379 Reviewed by: Pau Amma , markj Differential Revision: https://reviews.freebsd.org/D34947 (cherry picked from commit e6dede145616ed8f98c629c23a2ba206b812c921) sbin/setkey/setkey.8 | 74 ++++++++++++++++++++++++++++--------------------= ---- 1 file changed, 40 insertions(+), 34 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=