From nobody Thu Mar 03 17:37:44 2022 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 48BBD19E83AE for ; Thu, 3 Mar 2022 17:37:57 +0000 (UTC) (envelope-from SRS0=WrSORx=TO=codenetworks.net=sm@eigbox.net) Received: from bosmailout06.eigbox.net (bosmailout06.eigbox.net [66.96.184.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4K8dVX2fBcz4dMx for ; Thu, 3 Mar 2022 17:37:56 +0000 (UTC) (envelope-from SRS0=WrSORx=TO=codenetworks.net=sm@eigbox.net) Received: from bosmailscan09.eigbox.net ([10.20.15.9]) by bosmailout06.eigbox.net with esmtp (Exim) id 1nPpOg-0003KW-BF for freebsd-net@freebsd.org; Thu, 03 Mar 2022 12:37:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codenetworks.net; s=dkim; h=Sender:Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:To:Subject:MIME-Version:Date:Message-ID:Reply-To: Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mjgWU7UOm8DglHKTbmsntIPTKk8vn+HT31zXdfq1khI=; b=ZR5ajsjhCKoZzY2ZgBf1ecC/FH lmwWghuqmXNjyXlBtEbFsPNt+0yC9lITkXRrFkphJsdv8wbNsh7iXcYIsKjHWjP5dMe52bQuzyPGD 1VOgPd2f/2xJlz9B98Gz6uIg2UiKFv8Al86wf9KOYpPWu1EkPbzX7yft6KzVU6mFm0dkMEvuKrq1M 7S3hSxWElqZ3UzJiVn6qDiqAl06wLo1+lSia2XAHl9PpXvhf1mZS6Oap/2O70xBmpAibMln0tRSxP PKL6mRjkNdIxc0TNgU9u/56oq6Y3gqqH146u5fHnICE53zwNc9h1KdS6PUkdEMBkXP79iH+IlGvXT 0K+Jsusw==; Received: from [10.115.3.33] (helo=bosimpout13) by bosmailscan09.eigbox.net with esmtp (Exim) id 1nPpOf-0001At-Ur for freebsd-net@freebsd.org; Thu, 03 Mar 2022 12:37:49 -0500 Received: from bosauthsmtp10.yourhostingaccount.com ([10.20.18.10]) by bosimpout13 with id 1tdm2700X0D2CUy01tdpDj; Thu, 03 Mar 2022 12:37:49 -0500 X-Authority-Analysis: v=2.3 cv=RNUo47q+ c=1 sm=1 tr=0 a=Kpo39fPXdbgqDwiI3/AEUA==:117 a=Ek/qOh1uPkKSHvd30yk7rg==:17 a=IkcTkHD0fZMA:10 a=o8Y5sQTvuykA:10 a=-Yl_685HdVUA:10 a=yBRpR3YrdbeeFIZ9fW0A:9 a=QEXdDO2ut3YA:10 Received: from cm-81-9-194-73.telecable.es ([81.9.194.73]:26247 helo=[192.168.1.100]) by bosauthsmtp10.eigbox.net with esmtpa (Exim) id 1nPpOc-0005EX-Hm for freebsd-net@freebsd.org; Thu, 03 Mar 2022 12:37:46 -0500 Message-ID: <4dffe2f4-db80-6043-3083-4948572b9e8a@codenetworks.net> Date: Thu, 3 Mar 2022 18:37:44 +0100 List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: Current with RSS and EPAIR and without INET6. Content-Language: en-US To: freebsd-net@freebsd.org References: <0687A548-41D3-4D84-A83B-B2C0A87056BC@gmail.com> <9AC37B44-217F-4FE3-BAB3-482330F533AF@FreeBSD.org> <19c46030-0618-721a-7947-54142f50a943@codenetworks.net> <7f1b3db6-07e0-8919-072f-cc764194814c@codenetworks.net> From: Santiago Martinez In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-EN-UserInfo: d3bdfab0736480cedf04ed92aaea2ef5:931c98230c6409dcc37fa7e93b490c27 X-EN-AuthUser: sm@codenetworks.net X-EN-OrigIP: 81.9.194.73 X-EN-OrigHost: cm-81-9-194-73.telecable.es X-Rspamd-Queue-Id: 4K8dVX2fBcz4dMx X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none ("invalid DKIM record") header.d=codenetworks.net header.s=dkim header.b=ZR5ajsjh; dmarc=none; spf=pass (mx1.freebsd.org: domain of "SRS0=WrSORx=TO=codenetworks.net=sm@eigbox.net" designates 66.96.184.6 as permitted sender) smtp.mailfrom="SRS0=WrSORx=TO=codenetworks.net=sm@eigbox.net" X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.96.128.0/18]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[codenetworks.net: no valid DMARC record]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_TRACE(0.00)[codenetworks.net:~]; NEURAL_HAM_SHORT(-1.00)[-0.996]; RCVD_IN_DNSWL_NONE(0.00)[66.96.184.6:from]; R_DKIM_PERMFAIL(0.00)[codenetworks.net:s=dkim]; MLMMJ_DEST(0.00)[freebsd-net]; FORGED_SENDER(0.30)[sm@codenetworks.net,SRS0=WrSORx=TO=codenetworks.net=sm@eigbox.net]; RECEIVED_SPAMHAUS_PBL(0.00)[81.9.194.73:received]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:29873, ipnet:66.96.128.0/18, country:US]; FROM_NEQ_ENVFROM(0.00)[sm@codenetworks.net,SRS0=WrSORx=TO=codenetworks.net=sm@eigbox.net]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Thanks Kristof! Santi On 3/3/22 18:32, Kristof Provost wrote: > Thanks! > > Pushed as 52bcdc5b809ea56cbdce0bd36499e4ae74780d2b. > > Kristof > > On 2 Mar 2022, at 23:24, Santiago Martinez wrote: >> Hi Kristof and Zhenlei, >> >> I have updated the patch as requested (wrapped the ifdef INET|INET6 inside the ifdef RSS). >> >> It now works without INET6 or without INET. (only tested module loading and interface creation on both cases v4/6). >> >> Best regards. >> >> Santi >> >> @@ -73,8 +73,12 @@__FBSDID("$FreeBSD$"); >> #include >> #ifdef RSS >> #include >> +#ifdef INET >> #include >> +#endif >> +#ifdef INET6 >> #include >> +#endif >> #endif >> #include >> >> @@ -217,12 +221,16 @@epair_menq(struct mbuf *m, struct epair_softc *osc) >>                eh = mtod(m, struct ether_header *); >> >>                switch (ntohs(eh->ether_type)) { >> +#ifdef INET >>                case ETHERTYPE_IP: >>                        rss_soft_m2cpuid_v4(m, 0, &bucket); >>                        break; >> +#endif >> +#ifdef INET6 >>                case ETHERTYPE_IPV6: >>                        rss_soft_m2cpuid_v6(m, 0, &bucket); >>                        break; >> +#endif >>                default: >>                        bucket = 0; >>                        break; >> >> >> >> >> On 3/2/22 20:12, Santiago Martinez wrote: >>> Hi Kristof, sorry for my late reply. Im testing without INET. >>> >>> I will keep you updated. >>> >>> Santi >>> >>> >>> On 2/28/22 21:20, Kristof Provost wrote: >>>> On 28 Feb 2022, at 21:16, Santiago Martinez wrote: >>>>> Hi there , yes good point , the first ifdef should go inside the RSS ifdef . Will modify it to also work with INET6 only. Thanks for the feedback. >>>>> Santi >>>>> >>>>> >>>> Can you copy me on your updated patch? I’ll commit that. >>>> >>>> Thanks for finding and reporting this. >>>> >>>> Kristof >>>> >> >