From nobody Wed Mar 02 22:24:56 2022 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4FDC219EA844 for ; Wed, 2 Mar 2022 22:25:12 +0000 (UTC) (envelope-from SRS0=KkFH6L=TN=codenetworks.net=sm@eigbox.net) Received: from bosmailout10.eigbox.net (bosmailout10.eigbox.net [66.96.189.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4K87wR2Qr2z3m4T for ; Wed, 2 Mar 2022 22:25:11 +0000 (UTC) (envelope-from SRS0=KkFH6L=TN=codenetworks.net=sm@eigbox.net) Received: from bosmailscan04.eigbox.net ([10.20.15.4]) by bosmailout10.eigbox.net with esmtp (Exim) id 1nPXP7-0003WB-BN for freebsd-net@freebsd.org; Wed, 02 Mar 2022 17:25:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codenetworks.net; s=dkim; h=Sender:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Content-Type:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VRORJKBPTSnQU6Pw7W+czRUZA6fTV99JqLYoTmAGOTo=; b=HtvJ6Jy4KJI/++kHgtlsWTJL8 J5bLdXI+vIXGd8SdLBVBymjT98LNay9+3GBWjveUOPSlJC1svLKjvTwaY6taVg6OPej9Hm7ndKXgP kpYOgzAi5BhBFzPLmbTVwpEoYscD1esDHjp5tt9RWC4a/z8BmmrWSC69o/jCf1OTDXCEWQyns5kNO PaA7nB4H6948AHHGJPcVZJ8lfbJV10P3vwL+bu6B+SVTBTOwwq/vNoazNsgyCLeSLBjB52v7MnJbS xoeQukT6+eVPo+Mlcy7s0WHDjJbVUyzE4FV/iD/VZbGag2QbEg3X4dKCNqSnAUXBFtKmEiFApyn2z kb9lf7zyA==; Received: from [10.115.3.32] (helo=bosimpout12) by bosmailscan04.eigbox.net with esmtp (Exim) id 1nPXP6-0008S0-Qb for freebsd-net@freebsd.org; Wed, 02 Mar 2022 17:25:04 -0500 Received: from bosauthsmtp10.yourhostingaccount.com ([10.20.18.10]) by bosimpout12 with id 1aR12702H0D2CUy01aR4f5; Wed, 02 Mar 2022 17:25:04 -0500 X-Authority-Analysis: v=2.3 cv=d4VuNSrE c=1 sm=1 tr=0 a=Kpo39fPXdbgqDwiI3/AEUA==:117 a=Ek/qOh1uPkKSHvd30yk7rg==:17 a=o8Y5sQTvuykA:10 a=-Yl_685HdVUA:10 a=r77TgQKjGQsHNAKrUKIA:9 a=Oq8XANWxjg80uFT-xT0A:9 a=QEXdDO2ut3YA:10 a=jlvWEfeLAAAA:8 a=UpzDV5BqcctLRUNH6agA:9 a=AFU1dTopgSFI6RVc:21 a=_W_S_7VecoQA:10 a=BUduvz6nQKmfCEOu4uBS:22 Received: from cm-81-9-194-73.telecable.es ([81.9.194.73]:26372 helo=[192.168.1.100]) by bosauthsmtp10.eigbox.net with esmtpa (Exim) id 1nPXP3-0001Rt-FH; Wed, 02 Mar 2022 17:25:01 -0500 Content-Type: multipart/alternative; boundary="------------5i5ATyj0AEI50LkzKHF54NK3" Message-ID: <7f1b3db6-07e0-8919-072f-cc764194814c@codenetworks.net> Date: Wed, 2 Mar 2022 23:24:56 +0100 List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: Current with RSS and EPAIR and without INET6. Content-Language: en-US From: Santiago Martinez To: Kristof Provost , Zhenlei Huang Cc: freebsd-net@freebsd.org References: <0687A548-41D3-4D84-A83B-B2C0A87056BC@gmail.com> <9AC37B44-217F-4FE3-BAB3-482330F533AF@FreeBSD.org> <19c46030-0618-721a-7947-54142f50a943@codenetworks.net> In-Reply-To: <19c46030-0618-721a-7947-54142f50a943@codenetworks.net> X-EN-UserInfo: d3bdfab0736480cedf04ed92aaea2ef5:931c98230c6409dcc37fa7e93b490c27 X-EN-AuthUser: sm@codenetworks.net X-EN-OrigIP: 81.9.194.73 X-EN-OrigHost: cm-81-9-194-73.telecable.es X-Rspamd-Queue-Id: 4K87wR2Qr2z3m4T X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none ("invalid DKIM record") header.d=codenetworks.net header.s=dkim header.b=HtvJ6Jy4; dmarc=none; spf=pass (mx1.freebsd.org: domain of "SRS0=KkFH6L=TN=codenetworks.net=sm@eigbox.net" designates 66.96.189.10 as permitted sender) smtp.mailfrom="SRS0=KkFH6L=TN=codenetworks.net=sm@eigbox.net" X-Spamd-Result: default: False [-2.99 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.96.128.0/18]; DKIM_TRACE(0.00)[codenetworks.net:~]; NEURAL_HAM_SHORT(-0.99)[-0.993]; FREEMAIL_TO(0.00)[FreeBSD.org,gmail.com]; FORGED_SENDER(0.30)[sm@codenetworks.net,SRS0=KkFH6L=TN=codenetworks.net=sm@eigbox.net]; RECEIVED_SPAMHAUS_PBL(0.00)[81.9.194.73:received]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:29873, ipnet:66.96.128.0/18, country:US]; FROM_NEQ_ENVFROM(0.00)[sm@codenetworks.net,SRS0=KkFH6L=TN=codenetworks.net=sm@eigbox.net]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RCVD_COUNT_FIVE(0.00)[5]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[codenetworks.net: no valid DMARC record]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[66.96.189.10:from]; R_DKIM_PERMFAIL(0.00)[codenetworks.net:s=dkim]; MLMMJ_DEST(0.00)[freebsd-net]; RWL_MAILSPIKE_POSSIBLE(0.00)[66.96.189.10:from] X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --------------5i5ATyj0AEI50LkzKHF54NK3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Kristof and Zhenlei, I have updated the patch as requested (wrapped the ifdef INET|INET6 inside the ifdef RSS). It now works without INET6 or without INET. (only tested module loading and interface creation on both cases v4/6). Best regards. Santi @@ -73,8 +73,12 @@__FBSDID("$FreeBSD$"); #include #ifdef RSS #include +#ifdef INET #include +#endif +#ifdef INET6 #include +#endif #endif #include @@ -217,12 +221,16 @@epair_menq(struct mbuf *m, struct epair_softc *osc)                eh = mtod(m, struct ether_header *);                switch (ntohs(eh->ether_type)) { +#ifdef INET                case ETHERTYPE_IP:                        rss_soft_m2cpuid_v4(m, 0, &bucket);                        break; +#endif +#ifdef INET6                case ETHERTYPE_IPV6:                        rss_soft_m2cpuid_v6(m, 0, &bucket);                        break; +#endif                default:                        bucket = 0;                        break; On 3/2/22 20:12, Santiago Martinez wrote: > Hi Kristof, sorry for my late reply. Im testing without INET. > > I will keep you updated. > > Santi > > > On 2/28/22 21:20, Kristof Provost wrote: >> On 28 Feb 2022, at 21:16, Santiago Martinez wrote: >>> Hi there , yes good point , the first ifdef should go inside the RSS >>> ifdef . Will modify it to also work with INET6 only. Thanks for the >>> feedback. >>> Santi >>> >>> >> Can you copy me on your updated patch? I’ll commit that. >> >> Thanks for finding and reporting this. >> >> Kristof >> > --------------5i5ATyj0AEI50LkzKHF54NK3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Kristof and Zhenlei,

I have updated the patch as requested (wrapped the ifdef INET|INET6 inside the ifdef RSS).

It now works without INET6 or without INET. (only tested module loading and interface creation on both cases v4/6).

Best regards.

Santi

@@ -73,8 +73,12 @@ __FBSDID("$FreeBSD$");
#include <net/netisr.h>
#ifdef RSS
#include <net/rss_config.h>
+#ifdef INET
#include <netinet/in_rss.h>
+#endif
+#ifdef INET6
#include <netinet6/in6_rss.h>
+#endif  
#endif
#include <net/vnet.h>
 
@@ -217,12 +221,16 @@ epair_menq(struct mbuf *m, struct epair_softc *osc)
               eh = mtod(m, struct ether_header *);
 
               switch (ntohs(eh->ether_type)) {
+#ifdef INET
               case ETHERTYPE_IP:
                       rss_soft_m2cpuid_v4(m, 0, &bucket);
                       break;
+#endif
+#ifdef INET6
               case ETHERTYPE_IPV6:
                       rss_soft_m2cpuid_v6(m, 0, &bucket);
                       break;
+#endif
               default:
                       bucket = 0;
                       break;




On 3/2/22 20:12, Santiago Martinez wrote:
Hi Kristof, sorry for my late reply. Im testing without INET.

I will keep you updated.

Santi


On 2/28/22 21:20, Kristof Provost wrote:
On 28 Feb 2022, at 21:16, Santiago Martinez wrote:
Hi there , yes good point , the first ifdef should go inside the RSS ifdef . Will modify it to also work with INET6 only. Thanks for the feedback.
Santi


Can you copy me on your updated patch? I’ll commit that.

Thanks for finding and reporting this.

Kristof


--------------5i5ATyj0AEI50LkzKHF54NK3--