From nobody Sun Jan 02 00:21:01 2022 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A330219154D8 for ; Sun, 2 Jan 2022 00:21:01 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JRKKn2mkhz3lXd; Sun, 2 Jan 2022 00:21:01 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:606c::16:b]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 40084C9; Sun, 2 Jan 2022 00:21:01 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 3EF5313D5D; Sun, 2 Jan 2022 00:21:01 +0000 (UTC) Date: Sun, 2 Jan 2022 00:21:01 +0000 To: Phabricator From: "emaste (Ed Maste)" Cc: freebsd-net@freebsd.org Reply-to: "emaste (Ed Maste)" Subject: [Differential] D33717: route: remove write-only struct hostent from getaddr() Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-zjrsejzgv3kp46yx4cfw X-Phabricator-Mail-ID: 2991587 X-Phabricator-Send-Attempt: 3neqog32yqnwstak In-Reply-To: References: Thread-Index: NzUyMTdmNmJjYzJiOGE2YTRjNjNjY2EzYjljIGHQ7+0= X-Phabricator-Stamps: actor(@emaste) application(Differential) author(@emaste) monogram(D33717) object-type(DREV) phid(PHID-DREV-zjrsejzgv3kp46yx4cfw) reviewer(@hrs) reviewer(@imp) reviewer(@melifaro) revision-status(needs-review) subscriber(@freebsd-net-list) via(web) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_e56df8d50aad1434fdad7d164b2d1b51" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641082861; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=1L0Fm+LsZNc0ol0We0xHdMUFoNhAIvjYpRLWoSCNNGQ=; b=rE0japzULvg4B0QAeF7Rj8EhgW3iqjFNqiPdPFW1y5M/Bv70A48lfNjUuh1FosqpIwO4Uh NH7gBzUm2OzNFhbU9qhHmMBcT5Z/Yg4oVBe1r8YgryNb3Mps55ewdP00JZFz5FhJANMQo+ 3IGvWx3YXmGdN7yc1dOD54sw4Y2ndishfnVBcfIWYyvZvxELgaijB2gr//HpOmwr8o0Tk7 jgrlk44Uas3DCEI6sJtrHkt/n01sGE+mnAnHY7y3EJEMSaqCZyIiW/wHta/weIn8sI53Qd wPI1dOIaqN522w+WvSbfAyBA/uTyH/+nWWUBQrS8aq2/ZfxrkKv3RsaN5rNhqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641082861; a=rsa-sha256; cv=none; b=u9rQYz4xHWHILzVnySb0Wgsw3QwcbJb46HqnP3FwdNab9IQpJLXMCwggAgYLX9eJqquYJp AFgq9/26eeqactl9kzvQCNmokTPSWeWqOFa/bIvW97HvEN6qA0GW6jprslf22GToE1QqB/ dXkSEhymhfLPRfwNbz2/ftiGK7ESInd9Fgn4paSTPiDp4gNTZuTDN4dgCIJNA5Mga/mll7 f7UpkjCsT4Tl6FCQpjdhoRcd6vAbXUIS3zeR+CCBixDkeuwCvIzvQYxgl4Se2hj9bdc1Q0 TeduSPhHKoC8B0ryzgIvHol0MEiK2z4kmQB8SwnZNzcBJiQp3k1a6qs8YRXjKg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --b1_e56df8d50aad1434fdad7d164b2d1b51 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 ZW1hc3RlIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDEwMDgxNS4KZW1hc3RlIGFkZGVk IHJldmlld2VyczogbWVsaWZhcm8sIGltcCwgaHJzLgplbWFzdGUgYWRkZWQgYSBzdWJzY3JpYmVy OiBmcmVlYnNkLW5ldC1saXN0LgoKQ0hBTkdFUyBTSU5DRSBMQVNUIFVQREFURQogIGh0dHBzOi8v cmV2aWV3cy5mcmVlYnNkLm9yZy9EMzM3MTc/dnM9MTAwODE0JmlkPTEwMDgxNQoKQ0hBTkdFUyBT SU5DRSBMQVNUIEFDVElPTgogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EMzM3MTcvbmV3 LwoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0QzMzcxNwoK QUZGRUNURUQgRklMRVMKICBzYmluL3JvdXRlL3JvdXRlLmMKCkVNQUlMIFBSRUZFUkVOQ0VTCiAg aHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5j ZXMvCgpUbzogZW1hc3RlLCBtZWxpZmFybywgaW1wLCBocnMKQ2M6IGZyZWVic2QtbmV0LWxpc3QK --b1_e56df8d50aad1434fdad7d164b2d1b51 Content-Type: text/x-patch; charset=utf-8; name="D33717.100815.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D33717.100815.patch" ZGlmZiAtLWdpdCBhL3NiaW4vcm91dGUvcm91dGUuYyBiL3NiaW4vcm91dGUvcm91dGUuYwotLS0g YS9zYmluL3JvdXRlL3JvdXRlLmMKKysrIGIvc2Jpbi9yb3V0ZS9yb3V0ZS5jCkBAIC0xMTcsNyAr MTE3LDcgQEAKIHN0YXRpYyB2b2lkCXByaW50YihpbnQsIGNvbnN0IGNoYXIgKik7CiBzdGF0aWMg dm9pZAlmbHVzaHJvdXRlcyhpbnQgYXJnYywgY2hhciAqYXJndltdKTsKIHN0YXRpYyBpbnQJZmx1 c2hyb3V0ZXNfZmliKGludCk7Ci1zdGF0aWMgaW50CWdldGFkZHIoaW50LCBjaGFyICosIHN0cnVj dCBob3N0ZW50ICoqLCBpbnQpOworc3RhdGljIGludAlnZXRhZGRyKGludCwgY2hhciAqLCBpbnQp Owogc3RhdGljIGludAlrZXl3b3JkKGNvbnN0IGNoYXIgKik7CiAjaWZkZWYgSU5FVAogc3RhdGlj IHZvaWQJaW5ldF9tYWtlbWFzayhzdHJ1Y3Qgc29ja2FkZHJfaW4gKiwgdV9sb25nKTsKQEAgLTg5 MywzNSArODkzLDM1IEBACiAJCQljYXNlIEtfSUZBOgogCQkJCWlmICghLS1hcmdjKQogCQkJCQl1 c2FnZShOVUxMKTsKLQkJCQlnZXRhZGRyKFJUQVhfSUZBLCAqKythcmd2LCBOVUxMLCBucmZsYWdz KTsKKwkJCQlnZXRhZGRyKFJUQVhfSUZBLCAqKythcmd2LCBucmZsYWdzKTsKIAkJCQlicmVhazsK IAkJCWNhc2UgS19JRlA6CiAJCQkJaWYgKCEtLWFyZ2MpCiAJCQkJCXVzYWdlKE5VTEwpOwotCQkJ CWdldGFkZHIoUlRBWF9JRlAsICorK2FyZ3YsIE5VTEwsIG5yZmxhZ3MpOworCQkJCWdldGFkZHIo UlRBWF9JRlAsICorK2FyZ3YsIG5yZmxhZ3MpOwogCQkJCWJyZWFrOwogCQkJY2FzZSBLX0dFTk1B U0s6CiAJCQkJaWYgKCEtLWFyZ2MpCiAJCQkJCXVzYWdlKE5VTEwpOwotCQkJCWdldGFkZHIoUlRB WF9HRU5NQVNLLCAqKythcmd2LCBOVUxMLCBucmZsYWdzKTsKKwkJCQlnZXRhZGRyKFJUQVhfR0VO TUFTSywgKisrYXJndiwgbnJmbGFncyk7CiAJCQkJYnJlYWs7CiAJCQljYXNlIEtfR0FURVdBWToK IAkJCQlpZiAoIS0tYXJnYykKIAkJCQkJdXNhZ2UoTlVMTCk7Ci0JCQkJZ2V0YWRkcihSVEFYX0dB VEVXQVksICorK2FyZ3YsIE5VTEwsIG5yZmxhZ3MpOworCQkJCWdldGFkZHIoUlRBWF9HQVRFV0FZ LCAqKythcmd2LCBucmZsYWdzKTsKIAkJCQlnYXRld2F5ID0gKmFyZ3Y7CiAJCQkJYnJlYWs7CiAJ CQljYXNlIEtfRFNUOgogCQkJCWlmICghLS1hcmdjKQogCQkJCQl1c2FnZShOVUxMKTsKLQkJCQlp ZiAoZ2V0YWRkcihSVEFYX0RTVCwgKisrYXJndiwgJmhwLCBucmZsYWdzKSkKKwkJCQlpZiAoZ2V0 YWRkcihSVEFYX0RTVCwgKisrYXJndiwgbnJmbGFncykpCiAJCQkJCW5yZmxhZ3MgfD0gRl9JU0hP U1Q7CiAJCQkJZGVzdCA9ICphcmd2OwogCQkJCWJyZWFrOwogCQkJY2FzZSBLX05FVE1BU0s6CiAJ CQkJaWYgKCEtLWFyZ2MpCiAJCQkJCXVzYWdlKE5VTEwpOwotCQkJCWdldGFkZHIoUlRBWF9ORVRN QVNLLCAqKythcmd2LCBOVUxMLCBucmZsYWdzKTsKKwkJCQlnZXRhZGRyKFJUQVhfTkVUTUFTSywg KisrYXJndiwgbnJmbGFncyk7CiAJCQkJLyogRkFMTFRIUk9VR0ggKi8KIAkJCWNhc2UgS19ORVQ6 CiAJCQkJbnJmbGFncyB8PSBGX0ZPUkNFTkVUOwpAQCAtOTU2LDEzICs5NTYsMTMgQEAKIAkJfSBl bHNlIHsKIAkJCWlmICgocnRtX2FkZHJzICYgUlRBX0RTVCkgPT0gMCkgewogCQkJCWRlc3QgPSAq YXJndjsKLQkJCQlpZiAoZ2V0YWRkcihSVEFYX0RTVCwgKmFyZ3YsICZocCwgbnJmbGFncykpCisJ CQkJaWYgKGdldGFkZHIoUlRBWF9EU1QsICphcmd2LCBucmZsYWdzKSkKIAkJCQkJbnJmbGFncyB8 PSBGX0lTSE9TVDsKIAkJCX0gZWxzZSBpZiAoKHJ0bV9hZGRycyAmIFJUQV9HQVRFV0FZKSA9PSAw KSB7CiAJCQkJZ2F0ZXdheSA9ICphcmd2OwotCQkJCWdldGFkZHIoUlRBWF9HQVRFV0FZLCAqYXJn diwgJmhwLCBucmZsYWdzKTsKKwkJCQlnZXRhZGRyKFJUQVhfR0FURVdBWSwgKmFyZ3YsIG5yZmxh Z3MpOwogCQkJfSBlbHNlIHsKLQkJCQlnZXRhZGRyKFJUQVhfTkVUTUFTSywgKmFyZ3YsIE5VTEws IG5yZmxhZ3MpOworCQkJCWdldGFkZHIoUlRBWF9ORVRNQVNLLCAqYXJndiwgbnJmbGFncyk7CiAJ CQkJbnJmbGFncyB8PSBGX0ZPUkNFTkVUOwogCQkJfQogCQl9CkBAIC0xMTU0LDcgKzExNTQsNyBA QAogICogcmV0dXJuaW5nIDEgaWYgYSBob3N0IGFkZHJlc3MsIDAgaWYgYSBuZXR3b3JrIGFkZHJl c3MuCiAgKi8KIHN0YXRpYyBpbnQKLWdldGFkZHIoaW50IGlkeCwgY2hhciAqc3RyLCBzdHJ1Y3Qg aG9zdGVudCAqKmhwcCwgaW50IG5yZmxhZ3MpCitnZXRhZGRyKGludCBpZHgsIGNoYXIgKnN0ciwg aW50IG5yZmxhZ3MpCiB7CiAJc3RydWN0IHNvY2thZGRyICpzYTsKICNpZiBkZWZpbmVkKElORVQp CkBAIC0xMTc5LDkgKzExNzksNiBAQAogCQlhZmxlbiA9IHNpemVvZihzdHJ1Y3Qgc29ja2FkZHJf ZGwpOwogI2VuZGlmCiAJfQotI2lmbmRlZiBJTkVUCi0JaHBwID0gTlVMTDsKLSNlbmRpZgogCXJ0 bV9hZGRycyB8PSAoMSA8PCBpZHgpOwogCXNhID0gKHN0cnVjdCBzb2NrYWRkciAqKSZzb1tpZHhd OwogCXNhLT5zYV9mYW1pbHkgPSBhZjsKQEAgLTEyMzMsNyArMTIzMCw3IEBACiAJCXN3aXRjaCAo aWR4KSB7CiAJCWNhc2UgUlRBWF9EU1Q6CiAJCQlucmZsYWdzIHw9IEZfRk9SQ0VORVQ7Ci0JCQln ZXRhZGRyKFJUQVhfTkVUTUFTSywgc3RyLCBOVUxMLCBucmZsYWdzKTsKKwkJCWdldGFkZHIoUlRB WF9ORVRNQVNLLCBzdHIsIG5yZmxhZ3MpOwogCQkJYnJlYWs7CiAJCX0KIAkJcmV0dXJuICgwKTsK QEAgLTEyODAsOSArMTI3Nyw2IEBACiAKICNpZmRlZiBJTkVUCiAJc2luID0gKHN0cnVjdCBzb2Nr YWRkcl9pbiAqKSh2b2lkICopc2E7Ci0JaWYgKGhwcCA9PSBOVUxMKQotCQlocHAgPSAmaHA7Ci0J KmhwcCA9IE5VTEw7CiAKIAlxID0gc3RyY2hyKHN0ciwnLycpOwogCWlmIChxICE9IE5VTEwgJiYg aWR4ID09IFJUQVhfRFNUKSB7CkBAIC0xMzAzLDcgKzEyOTcsNiBAQAogCiAJaHAgPSBnZXRob3N0 YnluYW1lKHN0cik7CiAJaWYgKGhwICE9IE5VTEwpIHsKLQkJKmhwcCA9IGhwOwogCQlzaW4tPnNp bl9mYW1pbHkgPSBocC0+aF9hZGRydHlwZTsKIAkJbWVtbW92ZSgoY2hhciAqKSZzaW4tPnNpbl9h ZGRyLCBocC0+aF9hZGRyLAogCQkgICAgTUlOKChzaXplX3QpaHAtPmhfbGVuZ3RoLCBzaXplb2Yo c2luLT5zaW5fYWRkcikpKTsKCg== --b1_e56df8d50aad1434fdad7d164b2d1b51--