From nobody Sun Aug 14 22:37:43 2022 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M5XP96v8Gz4Ym0p for ; Sun, 14 Aug 2022 22:38:05 +0000 (UTC) (envelope-from woodsb02@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M5XP96SMJz3yZ1; Sun, 14 Aug 2022 22:38:05 +0000 (UTC) (envelope-from woodsb02@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660516685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTLxuZCs80hI5AEQ2q9XD4W1lXQgVWISyCFVfTSuPb8=; b=W5MPUqIZl9vR5ybaqCml0CiYG0T7rdxTil5Fq1hyH1KIqYUBWjrX+9jCEU03GmnJ1GJWwZ liyngt6Aojg2miy4d4oWFcqQoaP3gdDKlCzMklWeRP/YyMC41cgey/YPSg7D2mTXLWROaA Zze/jcKSN0PH92AZ6uWFLlVUSecj1dHorJ/ixDbwN9UZAxyvrnIVvHwNJz1xyFJku3dqRQ bjC92qzsySjJA4QZukKb1+MFP0C+lmjZsF0cEC8E6foyxcoBbJ9Wrfv522y/vJ22RnLRM7 L/ck0F0hZLepn4z0QnnYqDXP3U5zlsZQmWRfaZzj+7PCGx5F8olC0NbcUBSyNg== Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com [66.111.4.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: woodsb02) by smtp.freebsd.org (Postfix) with ESMTPSA id 4M5XP95DZzz1JNx; Sun, 14 Aug 2022 22:38:05 +0000 (UTC) (envelope-from woodsb02@freebsd.org) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id 9C1B827C0054; Sun, 14 Aug 2022 18:38:05 -0400 (EDT) Received: from imap46 ([10.202.2.96]) by compute2.internal (MEProxy); Sun, 14 Aug 2022 18:38:05 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehuddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvvefutgfgse htqhertderreejnecuhfhrohhmpedfuegvnhcuhghoohgushdfuceofihoohgushgstddv sehfrhgvvggsshgurdhorhhgqeenucggtffrrghtthgvrhhnpeevleegieeigfffhfeuke dugeeggffffeevtefgteeiueekhfegvdeftefgffekkeenucffohhmrghinheptghonhhf rdhnohdpfhhrvggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpegsvghnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhi thihqddutdelfeeiiedvkeekqddvgeejkedvvdektddqfihoohgushgstddvpeepfhhrvg gvsghsugdrohhrghesfihoohgushdrrghm X-ME-Proxy: Feedback-ID: if9c9472a:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6C5342A20075; Sun, 14 Aug 2022 18:38:05 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-841-g7899e99a45-fm-20220811.002-g7899e99a List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org Mime-Version: 1.0 Message-Id: In-Reply-To: <03de2ce0-b3ca-4dcb-a40b-1962fe740b44@www.fastmail.com> References: <20220807.232337.383956020917382126.hrs@FreeBSD.org> <4516f415-939e-6374-45ce-df19a2ac65cb@marples.name> <20220809.054039.722614217650843004.hrs@FreeBSD.org> <74a1d9c2-6eab-b685-e71e-7d69a6fe6a9f@marples.name> <03de2ce0-b3ca-4dcb-a40b-1962fe740b44@www.fastmail.com> Date: Mon, 15 Aug 2022 06:37:43 +0800 From: "Ben Woods" To: freebsd-net@freebsd.org Cc: "Hiroki Sato" , emaste@freebsd.org, "Roy Marples" , brooks@freebsd.org, cy@freebsd.org, "Philip Paeps" Subject: Re: Import dhcpcd(8) into FreeBSD base Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660516685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTLxuZCs80hI5AEQ2q9XD4W1lXQgVWISyCFVfTSuPb8=; b=ZLppvca+3kbnRPYkZ0Mb5LefvtzoGlltzZPSSw+u5YElWG/xgPeOOms8cTH0mZ+tEm2K7t nFRXiC9UAz0QeRMiRWmhdrfe50u3HD4Pjz7BYBbSibV0BLuteghW/UWmvLDnFhbciO7mWq ntVJ+AtTvGMVmR53bKPfj0dIHTvFCwf6Bui3FgZzd476d8ANh2uW/rPnh0imxSibucGsZT e4Rv+WDce/quy4S1bcpOrNJxaLdpaiBsHNv1huhhNWvFGsVFbbUSlEdVPSrjwGBZ6lnoYU ffnhXFZyrLA/lKCCgLsIQHs8SKEE8ESBHoGxac4WzKeKve5S6L/5sxn/3SZwbA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660516685; a=rsa-sha256; cv=none; b=pCYhDjdnIi3yccLyeydIO7N7byMDEocYf1f5G9KmGZxysGiK8VWYVUCc67iSbb4RqPGfiQ 6g0tPZ/fJEulOt+F/z3LIvQl/jGwA0ZbFLH24GtDGBR5RR4kFYaQMh5QIrdxGH37qXS9Gl mjmSwgN6F7IF1Z40mMy8R3j1cyaiY/z5Mu3hEFTzybkNLL0fqroJVHvo+iq6yAWWfYgOsl r3kS1jo1viU3lYCziq0B34q9WyG8N2ePo5Pz9sNwEC0aUXpXkMAtj5KdIJHVKFusuDdTGt lx9J9rqRnfu8GxkoDW6Z5TZRABeXRRC1Eu/8/gp2z28LSIS0vAVjucygG+SBig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, 10 Aug 2022, at 8:46 AM, Ben Woods wrote: > > I agree with the plan also - Import dhcpcd with its dedicated rc.d=20 > script (build enabled with runtime off by default, but manually enable= d=20 > by dhcpcd_enable=3D=E2=80=9CYES=E2=80=9D). > > No need to change the rc or network.subr system for now, as dhclient=20 > and rtsold are already off by default (or if enabled by default will b= e=20 > possible to disable in rc.conf). > > No need to have plans to remove dhclient/rtsold now - let=E2=80=99s gi= ve people=20 > the option for now, with no plan to necessarily remove dhclient/rtsold. > > Hiroki - I=E2=80=99ll update my phabricator review to align with the a= bove. > > Regards, > Ben > > --=20 > From: Ben Woods > woodsb02@freebsd.org Ok, I believe I now have this in a state which is ready to land in FreeB= SD, and would welcome any comments before doing so. Also, as previously mentioned, I have a ports commit bit, so would need = a src committer to approve me committing or commit on my behalf. I have 2 differential reviews for this: https://reviews.freebsd.org/D36196 - Create vendor branch vendor/dhcpcd https://reviews.freebsd.org/D22012 - Import dhcpcd into FreeBSD base The first review is new, and I=E2=80=99m not sure if it is normal to rev= iew vendor branch creations, but at a minimum I need approval to do so. The second review has now been updated to remove any changes to rc scrip= ts other than adding the new=E2=80=A8/etc/rc.d/dhcpcd. It is built/insta= lled by default, but not run by default. Do people think there should be= a WITH_DHCPCD build knob (on by default) to allow it to not be built (e= .g. save space on embedded systems)? Regards, Ben --=20 From: Ben Woods woodsb02@freebsd.org