[Bug 230996] em/igb: Intel i210/i350: ifconfig: enabling "vlanhwtag" renders VLAN on i210/i350 NICs unusable

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 28 Sep 2021 23:53:28 UTC

--- Comment #42 from Jason Tubnor <jason@tubnor.net> ---
I have added a comment to the review. I received an undeclared identifier:

/usr/src/sys/dev/e1000/if_em.c:3329:28: error: use of undeclared identifier
'pszie'; did you mean 'psize'?
                                e1000_rlpml_set_vf(hw, pszie);
/usr/src/sys/dev/e1000/if_em.c:3320:7: note: 'psize' declared here
                u32 psize, srrctl = 0;
1 error generated.
*** Error code 1



Changed the above to psize and all built and runs ok. Looking at the commit,
this was fixed between revision and commit.

Testing on stacked VLAN igb interfaces works as intended on 13-STABLE-20210923
without removing any interface options (was working fine before the patch), so
no regression with existing systems. Also tested where VLANs were added to
bridges and bhyve guest taps added to the bridge and no performance regressions
were identified on the guests or hosts.

Not tested with 12-stable.

You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.