From nobody Sun Jun 13 07:26:34 2021 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C04ED11D2042 for ; Sun, 13 Jun 2021 07:26:37 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G2mNY4lxQz50PM; Sun, 13 Jun 2021 07:26:37 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 7195C2E944; Sun, 13 Jun 2021 07:26:37 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 47FEE376D9; Sun, 13 Jun 2021 09:26:35 +0200 (CEST) From: "Kristof Provost" To: "Andriy Gapon" Cc: net@FreeBSD.org Subject: Re: page fault in pfioctl Date: Sun, 13 Jun 2021 09:26:34 +0200 X-Mailer: MailMate (1.13.2r5673) Message-ID: In-Reply-To: References: List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 12 Jun 2021, at 19:59, Andriy Gapon wrote: > Not sure if this has been reported, or maybe even fixed, yet. > The crash happened with stable/13 as of 92f49c769b4 (June 3). > Judging from the time I think that it happened when running a periodic > report (likely 520.pfdenied). > I have the vmcore, can take a look into it on Monday. > > Ah, and I must add that this is a custom kernel configuration with > INVARIANTS. > > Kernel page fault with the following non-sleepable locks held: > exclusive rm pf rulesets (pf rulesets) r = 0 (0xffffffff85558e58) > locked @ /usr/devel/git/trant/sys/netpfil/pf/pf_ioctl.c:2459 > This panic doesn’t seem to ring any bells for me. I’d be interested in seeing what kgdb can pull out of the vmcore. The line number for the lock would suggest it happened in DIOCGETRULENV, and the backtrace suggests it’s during the copyout. I’m just not sure how that’d panic, because we copy out the result of nvlist_pack() (and have checked that for NULL), using the size it gave us. Hopefully the vmcore will be more enlightening. That is fairly new code though, so bugs are not impossible. Best regards, Kristof