From nobody Tue Dec 21 23:40:26 2021 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 016121905223 for ; Tue, 21 Dec 2021 23:40:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JJXy26z2fz3t68 for ; Tue, 21 Dec 2021 23:40:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A7B1513042 for ; Tue, 21 Dec 2021 23:40:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1BLNeQ2U089227 for ; Tue, 21 Dec 2021 23:40:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1BLNeQKp089226 for net@FreeBSD.org; Tue, 21 Dec 2021 23:40:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 260393] Page Fault tcp_output/tcp_input Date: Tue, 21 Dec 2021 23:40:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: hselasky@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1640130027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MufQLmVAOC2X4cTkLZxYkdZJ0VN6U5QxTKV3GK6vipM=; b=jc6gEX57l8TWiClZCuCr06+66yonHZB9rJoPgBVaORBhm6cJYls51X+FIgXmAtRoBqoHbl 3AdvhAU2zIE7+UIhzgIimT8THl685pEi3IIhMuojyfoCiGXaWdBM/xrLFcr9KmHh9yTMA1 qnUGQ7asBnyn9pIyLhSBdM6qhZoZ0HBlElx1Js6AwJ3xVGgLaYlDq6RMzXY9qNBAiSaM8+ dxFEOGpWtFvFmPhwXy7rxe1Vy/8Ct/1WgodEQsC3CiwFfCvjR/boL3mj76EKrFb1zB0mtY PdYKp+6wyrPdm1isIG5Mbc6Gnf6sL+dyusvm/p/3mVveO8P9a6VhQevI/VMB5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1640130027; a=rsa-sha256; cv=none; b=jNzDRjGtVlnUdcQbngJmIT+p3ERjBVGRoUyg1mia6X6qVkL3vwMs5QpyAi0aTs5Q86lOWZ pUCho51yZ3ua7FMRGAI7gSJouOU6se0+B11M7GYf285KDu8cwJPclMa4pjFMeyskX7TeQU 1WQlEUd1FRx0WrSpoBtp9pGEGz4NrWEC2qkroMWRoiavJd+1jYsetjeW9psZ6TnzNvsyfc Nt6gjzaNLyWBMsOBYZmekCMyhaN0k5Np07k49anL8uESqptpGsOr5JuW76cRBLhCz7/MCb WEpgHVHzT+n7bTKdr4aJRsxf27prdMbbUwWhQZ7BKOE9f13cK0TrTScmzNvVsg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260393 --- Comment #36 from Hans Petter Selasky --- Hi, I wonder if we need to subtract 1 from tp->snd_max, when TF_SENTFIN is set? t_state =3D 8=20 #define TCPS_LAST_ACK 8 /* had fin and close; await FIN ACK= */ t_flags =3D 554697333 =3D 0x21100275 #define TF_SENTFIN 0x00000010 /* have sent FIN */ I remember we did a similar fix some while back for SACK: /* * Exclude FIN sequence space in * the hole for the rescue retransmission, * and also don't create a hole, if only * the ACK for a FIN is outstanding. */ tcp_seq highdata =3D tp->snd_max; if (tp->t_flags & TF_SENTFIN) highdata--; Now in this piece of code leading up do the sbdrop() of 1 byte: if (tlen =3D=3D 0) { if (SEQ_GT(th->th_ack, tp->snd_una) && SEQ_LEQ(th->th_ack, tp->snd_max) && !IN_RECOVERY(tp->t_flags) && (to.to_flags & TOF_SACK) =3D=3D 0 && TAILQ_EMPTY(&tp->snd_holes)) { The SEQ_LEQ is compared against the wrong snd_max ? SEQ_LEQ(th->th_ack, tp->snd_max) --HPS --=20 You are receiving this mail because: You are the assignee for the bug.=