[Bug 254695] Hyper-V + TCP_BBR: Kernel Panic: Assertion in_epoch(net_epoch_preempt) failed at netinet/tcp_lro.c:1180

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 23 Aug 2021 12:57:16 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254695

--- Comment #34 from Gordon Bergling <gbe_at_FreeBSD.org> ---
I think I have found a way to enable TCP BBR and RACK on Hyper-V again with the
following patch, which adds NET_EPOCH{ENTER,EXIT} calls around
hn_chan_rollup(), in which the panic is happening.

diff --git a/sys/dev/hyperv/netvsc/if_hn.c b/sys/dev/hyperv/netvsc/if_hn.c
index cd0b5a5fa8b9..fa141adad9f6 100644
--- a/sys/dev/hyperv/netvsc/if_hn.c
+++ b/sys/dev/hyperv/netvsc/if_hn.c
_at__at_ -83,6 +83,7 _at__at_ __FBSDID("$FreeBSD$");
 #include <sys/taskqueue.h>
 #include <sys/buf_ring.h>
 #include <sys/eventhandler.h>
+#include <sys/epoch.h>

 #include <machine/atomic.h>
 #include <machine/in_cksum.h>
_at__at_ -2883,7 +2884,10 _at__at_ static void
 hn_chan_rollup(struct hn_rx_ring *rxr, struct hn_tx_ring *txr)
 {
 #if defined(INET) || defined(INET6)
+       struct epoch_tracker et;
+       NET_EPOCH_ENTER(et);
        tcp_lro_flush_all(&rxr->hn_lro);
+       NET_EPOCH_EXIT(et);
 #endif

        /*


If have been running with this change for about three days and haven't had a
panic since then.

One question remains before opening a differential for it. Should I place
something around these NET_EPOCH_* calls like HAVE_BBR or something?

The panic within tcp_lro_flush_all() happens only if TCP BBR or RACK are been
used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Received on Mon Aug 23 2021 - 12:57:16 UTC

Original text of this message