From nobody Fri Oct 31 10:18:56 2025 X-Original-To: multimedia@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cycQX2DLyz6FbZX for ; Fri, 31 Oct 2025 10:19:00 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cycQX1m5Xz3k2W for ; Fri, 31 Oct 2025 10:19:00 +0000 (UTC) (envelope-from avg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761905940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2tb64xB1Du5ci08dVpzpe2yBIz2UeJ+99gWHkVnNtp0=; b=tjh0TpuJxFVz2xgpQBguplnHc3LoJfNzpSXWbFVOm+bes+97pA96Hnkb74IFr14uPIoAvL tY0tkgXyK9Iz4knMvIEIJHEiVczpOzv18wEeWjJomh3CL8jBWZpjY8qOe63ID6eQNZ67Ri CjKD9nnmeP66n8ezNk97NROwcS6/4gZzEzPF5Tow+GiJdqRreEXJdwaOn+2vwSswUd+gla fgaqQrhaNxmSFP+1OTfjmmKkItzW6ZKFBlh8PzVVtYiRpWdJc6WVrcU78JOQSN3fRgCVyt SunkXKuxPscBrigfpjIufsWbH5aQ9PykynJEvZiWxWk0vl6RSejWC8CUYX+dKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761905940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2tb64xB1Du5ci08dVpzpe2yBIz2UeJ+99gWHkVnNtp0=; b=vsYJzebvCAth8neo6R6W4IJmtAS9Z0AY7IqCaPg6AtttjSr2LzKQdf+x7pCLDJx6n2TDJC lMk7/r5853r8OyBjwr+wTcFbAxOXuhZkUjybiehoAixrV6IpSGdU1qP1/q3tBQAbBwQSAi Y23e3TCeO0YhSrXFZYyyCJMRX8meJBTxlNTa3z3AKjHqc8CSCn415XiWD8lZePbFp0cNNd Z9jROtZQTJkzgbTzjvqeXFh4CnYrAfRRNbXKCB0HaftQW35gcwqSrsPoj+zeD6vxApQuqN 0ytff54E67Yy4QSppXtIMKyWnUxB2yT/gmpM0fxrsaxVDi16e54SQbE9Oq92Eg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761905940; a=rsa-sha256; cv=none; b=lEjB1jDovJCTsbs/dl0aVqvM0559SYqDrBTXbKcTEpYfYZh/eJnO0DjWKYepuQTOVgd0FF +tm0dE+WndTUmKmjjcqv2sN0Bi9qMt4XCiAthR9C6EaBqP+EM80D+sFyjvByM7iypQSKj6 awgzGiNrANLhWRd26jk/XPVgjBZ2gUCSEphpUdhJ+jPKZPAp+MWW6NX2roqrfJM97xYud9 HMBAcA5BHCVUVegn+ctNPAI3kHehhNLZbMu3fmU+DoK1vRJTzLkrQ6EexpKJrRA0rCYM2p IhSiXbT/NJyZfLqrz95N5oTLzQWDMSwT9N+cgrfAZs+Mkiy4Ui2LmqvTVhRnQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [192.168.0.88] (unknown [93.188.39.137]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: avg/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cycQW69PgzQcj for ; Fri, 31 Oct 2025 10:18:59 +0000 (UTC) (envelope-from avg@FreeBSD.org) Message-ID: <80b2e4c8-264f-4c0d-b672-3da3707be3ea@FreeBSD.org> Date: Fri, 31 Oct 2025 12:18:56 +0200 List-Id: Multimedia discussions List-Archive: https://lists.freebsd.org/archives/freebsd-multimedia List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-multimedia@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: multimedia/ffmpeg: fix symbol versioning problem on stable/14 From: Andriy Gapon To: multimedia@FreeBSD.org References: <638730b9-efec-4a3c-ae49-ab720c5c4522@FreeBSD.org> Content-Language: en-US Autocrypt: addr=avg@FreeBSD.org; keydata= xsDNBGcKrHEBDADRvwQOK0b/yo4ys5cs6bOQMhEh4xtfbaZ/CU00cpPgUip3sOZCdrtMWlRC g25z97prxE9pKueZi+HXDhIPpa9xl14ghqF4oYScuJ1i18HyiOH2y5Q3Vv/TtFiSzicd3EAu QgS3jVidpgDSPDdj2Yz3UxYpZ+PuFl6nOnvCvqOFcjUlzKCyPaiN2b86l1Nscmhnc+zQ/faB erUOEFEDQbWMA5YfXi8HrbeR16hfRfGt7E0aMDlIj9FIPIq71UWMN9CimPgs4+rbNr1MAlLa z4GxSDhVYZEY5rqtCzr+PLXboRQWnaUwXl0/biw9enf17NHdYv1SNAFTX2eC4dZ3qBVI74dS PgNprm+PMfz+6Hhs/dAv+Nan5nVhg3EFIjYTiy0MnjMSq8uI0v0ykpAGAcJJ5xl6d23aLxgN 6f0z6pJRCO0hGPgU7UzvFD0MxJxmbzqdT1R51KDan1oD41b+tjl2LMBuCDCoB0U44Pu0zLdp xMfFTxCXtwIYKIUxwd28jwMAEQEAAc0eQW5kcml5IEdhcG9uIDxhdmdARnJlZUJTRC5vcmc+ wsENBBMBCAA3FiEEmXvSmjiQFHPVOpLnzDOt5NLj67sFAmcKrHEFCQeEzgACGwMECwkIBwUV CAkKCwUWAgMBAAAKCRDMM63k0uPru5tSDACFK15LLbq89RSQ6QMnjiIm1t/wYJyumb519MHu Dhzxx1lbr8oghf0RHtF6kYRLQPaW2VdToi74pRobd3CN4bhZKDLSL6WfTn17RfavDjL6Njwp KBo30CkOeYKWq1mDmo0xEoQj8cc7ybEZnus+YScZOpj8Ti4EFwhRt6SHer7YDb161IHKL8m4 MsCxpFSGEjbKj8Iul3Ri/fTOO8w14ivcuEEQIvJt4/+4YV5Az8G23wKzL/3aJ7SOT3oYGmR9 atBTmVO3DlODjM+rZLegd8SfLSPTcBTHspWE5duemIzZbEX3BP77r3Qx4Fo5Tkit3bG1XVar yPQato+sFGFEGifdE9USBQoAoOaaeZevwAWjDU0TIuCT0CUe0sKtQuNP4LRq0n9EEHOXBu9a CfdMhFUSkAZnuE7miSVwgPvoVNJ1stA37EXLN/sVsWik7wslTQ5vF81VpdGFiwoQPOe2XEKh ogcwGSnXbwv1gD4x+Gz/7Y+kFyr1NY+4/nSaeXVcS2fOwM0EZwqscgEMAMQTe6ypAmQe/TFO HqKD2hfFKdksTptKi6uEh8xIwct8G/0FBldDWXo9eu8CGr/ZrDg0/bAwJxbaLRQCMH19Gq2Y hLvZ1QK5GQJVzZKcqfxbF2LiDUTs6WkdOBIhGpdDy7p1xFrvqCGCtNFYHuGYm067EozibBSF BWAPstKu2FQuVHZNMOfs7p3OIz3Yfqu9woXDeg3/8G2qVQJINe+8EwXKlhgh4CyDbq7nAZoA kIu1SE9z9u3WI5mcNy/0dFmVUsFxBqRC3ewbvzie8tKyZ9yFOlaZPT0Y4nRBXQTI3mLZ8zQ8 mtrWK5OOmrJ02kdeO9RBXe+OMaUUWMf92ZIoBFb4HP6N+B+4N1y1OwULousfl7JRoYxA4MRL ls7E2sSoJvrEBTJB3Pc34xu8rsJ1A5V3NgN6djX8yEZYpTRkcmrBeWy/ofDqZPVqneAx0LRm eldDS9msXDW4KXODyPZ+9unvmHAcoH0xaBYaSH44CDZDQDg4LNcmbOvuu1TEXBJhjQARAQAB wsD8BBgBCAAmFiEEmXvSmjiQFHPVOpLnzDOt5NLj67sFAmcKrHMFCQeEzgACGwwACgkQzDOt 5NLj67sUCAv5AXqgWnYN9EblapMbZjkiqL8pZQ0GNqh+Pg9FwbyULxjtRTO6rD4D0IxizByb ef+neeUNyYlagt5nfKMysEr0SU/gHKCi8vyTF/63ukMrGUNGmJJxrndl5ZYKC6j6eX7twrZF L1Uvlmn6FnQ22red5kHO93fDjG4zaDIZvHfwj7kzjZ4tpC7Byinf88s14mdZeScc0PnU2hj4 UGYju/wg2FF4YxaZYhcmdTiRYY0Wx85XSMZv19pnn78sadEuRvfRd4JTmw++j1xGXeqQGWzz /CTG5/Ex9GAkQ02hZbmi236byDXoet4G8TEyOph9QFVkV9bNd0jQZaFZPGEj4PSPUYGAF7s5 xJaNGgctC3aZ7WjEv1FBoo44XCU4xcjJ1wZQUrHxRhx6TW0Jtcl0U9qfKFW30TSPo6RyiXuj X4ltWKAtjoXB8nUmEJckaz7IRu2b4pXDeazZuz5JBygUs10yJjDxh2vFQZo0KaBAPx9MZlPn gpPTjT15L8xGftEjQXF6 In-Reply-To: <638730b9-efec-4a3c-ae49-ab720c5c4522@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit No interest at all? Or nobody is actually subscribed to this list? :-) On 25/09/2025 16:16, Andriy Gapon wrote: > > Preamble: I made this change a while ago but couldn't find time to share it. > Now I see that ffmpeg 8 is in the works, so maybe I am too late or, at least, > the change will need some rework. > The change addresses an issue similar to https://bugs.freebsd.org/bugzilla/ > show_bug.cgi?id=284651 and multiple others. > > commit 7f9d8df0bafbb3ffbe0399a28b8d232bb2c58612 > Author:     Andriy Gapon > AuthorDate: Sat Jun 21 17:16:33 2025 +0300 > Commit:     Andriy Gapon > CommitDate: Sat Sep 6 15:47:50 2025 +0300 > >     multimedia/ffmpeg: fix symbol versioning problem on stable/14 > >     This is a well-known issue related to visibility of environ and __progname >     symbols from /usr/lib/crt1.o. > >     This change patches configure to give those symbols global visibility >     when testing --version-script support. >     Otherwise, the port would produce broken libraries without symbol versions. > >     This change also adds HAS_SYMBOL_VERSION to catch the problem using >     libavcodec.so as a canary. > > diff --git a/multimedia/ffmpeg/Makefile b/multimedia/ffmpeg/Makefile > index f7c5d80adeac..fd25b9238021 100644 > --- a/multimedia/ffmpeg/Makefile > +++ b/multimedia/ffmpeg/Makefile > @@ -28,6 +28,7 @@ USE_PERL5=    build >  SHEBANG_FILES=    doc/texi2pod.pl >  NOPRECIOUSMAKEVARS=    yes # ARCH > > +HAS_SYMBOL_VERSION=    ${PREFIX}/lib/libavcodec.so >  PORTSCOUT=    limit:^6\. > >  # Option CHROMAPRINT disabled, it cannot work and people are baffled. > diff --git a/multimedia/ffmpeg/files/patch-configure b/multimedia/ffmpeg/files/ > patch-configure > index 9654237228cc..c3a166b984ca 100644 > --- a/multimedia/ffmpeg/files/patch-configure > +++ b/multimedia/ffmpeg/files/patch-configure > @@ -28,3 +28,12 @@ >                               -lSPVRemapper -lSPIRV -lSPIRV-Tools-opt -lSPIRV- > Tools -lpthread -lstdc++ -lm; } >   enabled libgme            && { check_pkg_config libgme libgme gme/gme.h > gme_new_emu || >                                  require libgme gme/gme.h gme_new_emu -lgme - > lstdc++; } > +@@ -7307,7 +7301,7 @@ > + EOF > + > + if enabled proper_dce; then > +-    echo "X { local: *; };" > $TMPV > ++    echo "X { global: environ; __progname; local: *; };" > $TMPV > +     if test_ldflags -Wl,${version_script},$TMPV; then > +         append SHFLAGS '-Wl,${version_script},\$(SUBDIR)lib\$(NAME).ver' > +         quotes='""' > > > -- Andriy Gapon