[Bug 286229] multimedia/vlc: Rework port and add nox11 flavour

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286229

--- Comment #16 from Gleb Popov <arrowd@FreeBSD.org> ---
It occured to me that with recent additions to pkg and Poudriere the
provides/requires mechanism would allow for dependency hot-swapping. Adding
nox11 flavor would prove being useful as we'll be able to depend on nox11 by
default but still allow the user to switch to the full VLC with a simple pkg
install.

This functionalty isn't live yet, but it is going to be merged soon (tm).

Regarding the patch itself - I don't like how adding a flavor leads to a giant
.if where you have to disable options and repeat CONFIGURE_ARGS. I'm also not
sure that it is allowed to put OPTIONS_UNSET into Makefile either.

I'd try a different approach I'm using for lang/ghc* - go the master/slave
route and put
OPTIONS_DEFINE=
into the slave Makefile. This will make all the option stuff in the master port
a no-op and will allow you to cleanly override master's definitions.

Also, it'd be nice to split cosmetic changes into a separate patch and push it
separately.

-- 
You are receiving this mail because:
You are the assignee for the bug.