maintainer-feedback requested: [Bug 278706] multimedia/vlc: fix build with FREERDP option ON: incompatible function pointer types

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 03 May 2024 00:25:08 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-multimedia
(Nobody) <multimedia@FreeBSD.org> for maintainer-feedback:
Bug 278706: multimedia/vlc: fix build with FREERDP option ON: incompatible
function pointer types
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278706



--- Description ---
Build log:

access/rdp.c:238:39: error: incompatible function pointer types assigning to
'pDesktopResize' (aka 'int (*)(struct rdp_context *)') from 'void (rdpContext
*)' (aka 'void (struct rdp_context *)') [-Wincompatible-function-pointer-types]
  238 |     p_instance->update->DesktopResize = desktopResizeHandler;
      | 				      ^ ~~~~~~~~~~~~~~~~~~~~
access/rdp.c:239:36: error: incompatible function pointer types assigning to
'pBeginPaint' (aka 'int (*)(struct rdp_context *)') from 'void (rdpContext *)'
(aka 'void (struct rdp_context *)') [-Wincompatible-function-pointer-types]
  239 |     p_instance->update->BeginPaint = beginPaintHandler;
      | 				   ^ ~~~~~~~~~~~~~~~~~
access/rdp.c:240:34: error: incompatible function pointer types assigning to
'pEndPaint' (aka 'int (*)(struct rdp_context *)') from 'void (rdpContext *)'
(aka 'void (struct rdp_context *)') [-Wincompatible-function-pointer-types]
  240 |     p_instance->update->EndPaint = endPaintHandler;
      | 				 ^ ~~~~~~~~~~~~~~~

access/rdp.c:427:35: error: incompatible function pointer types assigning to
'pPreConnect' (aka 'int (*)(struct rdp_freerdp *)') from 'bool (freerdp *)'
(aka 'bool (struct rdp_freerdp *)') [-Wincompatible-function-pointer-types]
  427 |     p_sys->p_instance->PreConnect = preConnectHandler;
      | 				  ^ ~~~~~~~~~~~~~~~~~
access/rdp.c:428:36: error: incompatible function pointer types assigning to
'pPostConnect' (aka 'int (*)(struct rdp_freerdp *)') from 'bool (freerdp *)'
(aka 'bool (struct rdp_freerdp *)') [-Wincompatible-function-pointer-types]
  428 |     p_sys->p_instance->PostConnect = postConnectHandler;
      | 				   ^ ~~~~~~~~~~~~~~~~~~
access/rdp.c:429:37: error: incompatible function pointer types assigning to
'pAuthenticate' (aka 'int (*)(struct rdp_freerdp *, char **, char **, char
**)') from 'bool (freerdp *, char **, char **, char **)' (aka 'bool (struct
rdp_freerdp *, char **, char **, char **)')
[-Wincompatible-function-pointer-types]
  429 |     p_sys->p_instance->Authenticate = authenticateHandler;
      | 				    ^ ~~~~~~~~~~~~~~~~~~~

Can be "fixed" with "CFLAGS=-Wno-error=incompatible-function-pointer-types".