maintainer-feedback requested: [Bug 276469] multimedia/ffmpeg4: build error with GLSLANG option set

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 20 Jan 2024 05:49:31 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-multimedia
(Nobody) <multimedia@FreeBSD.org> for maintainer-feedback:
Bug 276469: multimedia/ffmpeg4: build error with GLSLANG option set
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276469



--- Description ---
After the PORTREVISION bump due to "multimedia/libvpx: update 1.14.0"
(589aaaeb09b7daeb6a2053a684f5056d9fcfed0e) I'm facing an error while building
multimedia/ffmpeg4 with GLSLANG option set:

libavfilter/glslang.cpp:164:5: error: use of undeclared identifier 'assert'
  164 |     assert(glslang_refcount);
      |     ^
2 warnings and 1 error generated.
gmake[2]: *** [ffbuild/common.mak:70: libavfilter/glslang.o] Error 1

Adding
    #include <assert.h>
in libavfilter/glslang.cpp fixed the build, but I'm not sure that is correct.


The ports has been previously built (from updated ports) on 31st Dec. 2023 with
success and the only change is the PORTREVISION bump 9=>10.

If that could be of interest, in the meanwhile...
- graphics/glslang has been updated (twice, on 4th Jan. 2024)
- I updated my box tracking stable/13 on 8th Jan. 2024, so llvm project in base
has been upgraded from version 16 to 17