[Bug 275268] multimedia/ffmpeg4: build failure with texinfo 7.1

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 24 Nov 2023 10:49:09 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275268

--- Comment #1 from Jan Beich <jbeich@FreeBSD.org> ---
I can't reproduce inside poudriere. Tested at least on FreeBSD 13.2 amd64, 12.4
i386. Is this a fix for non-default options or an update that hasn't landed
yet? Looking at the code it should be using texi2html, so texinfo error is
probably due to unclean build.

Can you document the build error (excerpt) being fixed in the commit message?
Also use "after <hash>" (in summary) or "Fixes: <hash>" (in body) to document
which commit regressed the build. Both are important for posterity or deciding
whether to cherry-pick into /quarterly or local branch (for vendors with
private forks). 

Can you move the links from "Obtained from" into the patch as header? This
helps deciding whether to to prune patches on updates. See files/patch-svtav1
or files/patch-vmaf or files/patch-libavfilter_vf__lensfun.c as examples. Also,
use /commitdiff/ links instead of /commit/ to make it easier to see the
upstream patch content. In the commit message "Obtained from: URL, URL, etc"
can be dropped (due to being obvious when looking at the patch) or replaced
with "Obtained from: upstream".

Besides, submit patches via "git format-patch" suitable for applying via "git
am" which helps to avoid mistakes if landed by someone else.

-- 
You are receiving this mail because:
You are the assignee for the bug.