maintainer-feedback requested: [Bug 270038] multimedia/vlc: fails with ASLR enabled

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 08 Mar 2023 13:58:34 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-multimedia
(Nobody) <multimedia@FreeBSD.org> for maintainer-feedback:
Bug 270038: multimedia/vlc: fails with ASLR enabled
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270038



--- Description ---
Ref. thread at
https://lists.freebsd.org/archives/freebsd-stable/2023-March/001178.html

Problem:
Some 1 or 2 minutes into the flight, vlc does continue to play A+V,
but the GUI does not react and does not get refreshed anymore. At
the same time, coredumps are generated (quite a lot of them).

And report that it works with noaslr tag:
https://lists.freebsd.org/archives/freebsd-stable/2023-March/001181.html

diff --git a/multimedia/vlc/Makefile b/multimedia/vlc/Makefile
index 4529d05caea5..c3df51cd2170 100644
--- a/multimedia/vlc/Makefile
+++ b/multimedia/vlc/Makefile
@@ -27,6 +27,8 @@ RUN_DEPENDS=	ffmpeg>=3.4.1,1:multimedia/ffmpeg

 USES=		compiler:c++17-lang cpe desktop-file-utils gettext-tools gmake
gnome \
		iconv:wchar_t libtool localbase pathfix pkgconfig tar:xz
+USES+= 	elfctl
+ELF_FEATURES+= +noaslr:bin/.libs/vlc

 CPE_VENDOR=	videolan

Looks good so far. The effect happens randomly in about 80% of
invocations (no idea about when and why), so no guarantee, but I don't
see reason why it shouldn't work.

In the short term we'll want to add the tag to the port.
We'll also need to investigate the cause of the failure and fix the underlying
problem (and revert the tagging).