[Bug 258720] multimedia/avidemux: update to 2.7.8

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 06 May 2022 13:01:20 UTC 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258720

--- Comment #22 from Tobias C. Berner <tcberner@freebsd.org> ---
Moin moin 

Could you explain why you chose to
.if ${PORT_OPTIONS:MVAPOURSYNTH}
.if ! ${USE_XORG:Mx11}
USE_XORG+=     x11
.endif
.endf
instead of simply 
VAPORSYNTH_USE=xorg=x11

Similar for example the VDPAU option:
.if ${PORT_OPTIONS:MVDPAU}
.if ! ${LIB_DEPENDS:Mlibvdpau.so}
LIB_DEPENDS+=├→→libvdpau.so:multimedia/libvdpau 
.endif
.endif
is overly complicated. Why not simply 
VDPAU_LIB_DEPENDS=libvdpau.so:multimedia/libvdpau 

Please see [1] for more information on the option handling.

mfg Tobias

[1]
https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-options

-- 
You are receiving this mail because:
You are the assignee for the bug.