maintainer-feedback requested: [Bug 281150] java/openjdk11: fix build with clang 19 on i386

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 31 Aug 2024 08:33:53 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-java (Nobody)
<java@FreeBSD.org> for maintainer-feedback:
Bug 281150: java/openjdk11: fix build with clang 19 on i386
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281150



--- Description ---
Clang 19 has a number of new warnings, and because java/openjdk11
compiles with -Werror by default, on i386 it results in errors similar
to:

   
/wrkdirs/usr/ports/java/openjdk11/work/jdk11u-jdk-11.0.24-8-1/src/java.desktop/
share/native/libharfbuzz/graph/../hb-algs.hh:1332:18:
error: builtin __has_trivial_assign is deprecated; use
__is_trivially_assignable instead [-Werror,-Wdeprecated-builtins]
     1332 |   static_assert (hb_is_trivially_copy_assignable (T), "");
	  |		     ^
   
/wrkdirs/usr/ports/java/openjdk11/work/jdk11u-jdk-11.0.24-8-1/src/java.desktop/
share/native/libharfbuzz/graph/../hb-meta.hh:204:44:
note: expanded from macro 'hb_is_trivially_copy_assignable'
      204 | #define hb_is_trivially_copy_assignable(T) __has_trivial_assign(T)
	  |					       ^

I propose to disable warnings-as-errors for this port, similar to what
is already done for openjdk17. It does not make sense to have this on by
default, unless you are an upstream maintainer.