[Bug 268223] java/openjdk8: fix build with clang 15

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268223

--- Comment #3 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/ports/commit/?id=d7146f6d335b360c5c9fb736cf49c7af939b77d7

commit d7146f6d335b360c5c9fb736cf49c7af939b77d7
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-12-07 14:53:48 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-12-18 17:23:58 +0000

    java/openjdk8: fix build with clang 15

    During an exp-run for llvm 15 (see bug 265425), it turned out that
    java/openjdk8 failed to build with clang 15:

       
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u352-b08.1/jdk/src/share/bin/splashscreen_stubs.c:64:30:
error: incompatible pointer to integer conversion returning 'void *' from a
function with result type 'int' [-Wint-conversion]
            INVOKE(SplashLoadMemory, NULL)(pdata, size);
                                     ^~~~
        /usr/include/sys/_null.h:34:14: note: expanded from macro 'NULL'
        #define NULL    ((void *)0)
                        ^~~~~~~~~~~
       
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u352-b08.1/jdk/src/share/bin/splashscreen_stubs.c:60:39:
note: expanded from macro 'INVOKE'
        #define INVOKE(name,def) _INVOKE(name,def,return)
                                              ^~~
       
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u352-b08.1/jdk/src/share/bin/splashscreen_stubs.c:57:25:
note: expanded from macro '_INVOKE'
            if (!proc) { return def; } \
                                ^~~
       
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u352-b08.1/jdk/src/share/bin/splashscreen_stubs.c:68:28:
error: incompatible pointer to integer conversion returning 'void *' from a
function with result type 'int' [-Wint-conversion]
            INVOKE(SplashLoadFile, NULL)(filename);
                                   ^~~~
        /usr/include/sys/_null.h:34:14: note: expanded from macro 'NULL'
        #define NULL    ((void *)0)
                        ^~~~~~~~~~~
       
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u352-b08.1/jdk/src/share/bin/splashscreen_stubs.c:60:39:
note: expanded from macro 'INVOKE'
        #define INVOKE(name,def) _INVOKE(name,def,return)
                                              ^~~
       
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u352-b08.1/jdk/src/share/bin/splashscreen_stubs.c:57:25:
note: expanded from macro '_INVOKE'
            if (!proc) { return def; } \
                                ^~~
        2 errors generated.

    Indeed, instead of the pointer value NULL, the integer value 0 should be
    used.

    PR:             268223
    Approved by:    portmgr (tcberner)
    MFH:            2022Q4

 .../patch-jdk_src_share_bin_splashscreen__stubs.c (new)  | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

-- 
You are receiving this mail because:
You are the assignee for the bug.