Re: Building world with FORTIFY_SOURCE (contrib/ and sys/contrib/ patches)

From: Dmitry Salychev <dsl_at_FreeBSD.org>
Date: Thu, 26 Jun 2025 08:55:23 UTC
Dmitry Salychev <dsl@FreeBSD.org> writes:

> Kyle Evans <kevans@FreeBSD.org> writes:
>
>> On 6/25/25 15:13, Dmitry Salychev wrote:
>>> Hi,
>>> I was trying to build world for arm64 with FORTIFY_SOURCE and
>>> several
>>> additional parameters:
>>> $ cat /etc/src-env.conf
>>> FORTIFY_SOURCE=2
>>> $ cat /etc/src.conf
>>> WITH_RETPOLINE=yes
>>> WITH_KERNEL_RETPOLINE=yes
>>> WITH_BIND_NOW=yes
>>> OPT_INIT_ALL=zero
>>> but got several errors and patched contrib/ and sys/contrib/:
>>> https://reviews.freebsd.org/D51047
>>> I'm going wrong direction, it seems. I'm not sure whether I've to
>>> patch
>>> that code at all. And if so, how to do it correctly in order not to
>>> override those changes later on when new versions will be imported into
>>> the repository?
>>> 
>>
>> I posted a response in phab, but then it hit me that I'm pretty sure
>> both of these are already fixed.  What revision is your tree at?
>>
>> libarchive: e2a605e7ab7ff83d15b1a0b994223768169b0f1e
>> ZFS (libtpool/tests): 6b70ffeb2a652ee76e763fb81ed777de2d97e873
>>
>> Thanks,
>>
>> Kyle Evans
>
> I'm building 19d0dd87189e with that patch on top. OK, I'll try the
> latest main.
>
> Regards,
> Dmitry

World for arm64 can be built with 905541dd6ba4, it seems :)
I'll try to bisect to see how those compilation errors were solved then.

Regards,
Dmitry

-- 
https://wiki.freebsd.org/DmitrySalychev