From nobody Wed May 15 12:39:44 2024 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VfXrT0W7rz5KpxR for ; Wed, 15 May 2024 12:40:41 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from mailgate.Leidinger.net (mailgate.leidinger.net [IPv6:2a00:1828:2000:313::1:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mailgate.leidinger.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VfXrS46Swz3xPC; Wed, 15 May 2024 12:40:40 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Authentication-Results: mx1.freebsd.org; none List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@FreeBSD.org MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leidinger.net; s=outgoing-alex; t=1715776832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nCRzEIPu10Z6sL8LY3/rQqbAoetqwjux/mI4kMnapUI=; b=s/qBJUg1Q34GIyBOxUj6QNe9O7PwgPDx0KxZPh+h4VjpZSaBcq9UVB3DBMdmfP9oRm10p6 KFc3Sri/1X/XzsbwUFozUmrSswdss95Z0ptbQGia1ffHYGXFiZXgBLrjLhxV5bEjEOyxj/ D3nFlMPVRdFDVqYsE1HzYi4JrxaRNvmy6YoCJM0B0w7FL9UVLgTkFsbKVBvaaFvXJboxkH 9YWWlivEPCtLIxZNATQ591ZuNzmmj5ne8rsEyxXH+qRtk3F4XGRxQ7121oXwKlhQe7e+mS Qrv3A9DS1DaY7rlCsgJDVuoDsz81o+eCbm7hxK29XCsiFyvuS3fHq2fE6P8ljQ== Date: Wed, 15 May 2024 14:39:44 +0200 From: Alexander Leidinger To: Kyle Evans Cc: "freebsd-hackers@FreeBSD.org" Subject: Re: Initial implementation of _FORTIFY_SOURCE In-Reply-To: References: <83ac28b8e8e79866facbde716b051340@Leidinger.net> <97f000a2-eba8-4767-91e3-d5f311fa4e72@FreeBSD.org> Message-ID: Organization: No organization, this is a private message. Content-Type: multipart/signed; protocol="application/pgp-signature"; boundary="=_a697ab9abdd776089dd8896cad57a970"; micalg=pgp-sha256 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:34240, ipnet:2a00:1828::/32, country:DE] X-Rspamd-Queue-Id: 4VfXrS46Swz3xPC This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --=_a697ab9abdd776089dd8896cad57a970 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Am 2024-05-15 01:15, schrieb Kyle Evans: > I've confirmed that this patch fixes libfido2, will commit shortly. I can confirm too. If I want to test this on more ports, I have to add -D_FORTIFY_SOURCE=2 to the CFLAGS / CSSFLAGS? Or rather do this: ---snip--- diff --git a/Mk/Features/ssp.mk b/Mk/Features/ssp.mk index 4213e6d668a..545e74bfa05 100644 --- a/Mk/Features/ssp.mk +++ b/Mk/Features/ssp.mk @@ -7,8 +7,10 @@ SSP_Include_MAINTAINER= portmgr@FreeBSD.org . if !defined(SSP_UNSAFE) && \ (! ${ARCH:Mmips*}) # Overridable as a user may want to use -fstack-protector-all -SSP_CFLAGS?= -fstack-protector-strong +SSP_CFLAGS?= -fstack-protector-strong -D_FORTIFY_SOURCE=2 +SSP_LDFLAGS?= -fstack-protector-strong CFLAGS+= ${SSP_CFLAGS} -LDFLAGS+= ${SSP_CFLAGS} +CXXFLAGS+= ${SSP_CFLAGS} +LDFLAGS+= ${SSP_LDFLAGS} . endif .endif ---snip--- Bye, Alexander. -- http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_a697ab9abdd776089dd8896cad57a970 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc; size=833 Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmZErR8ACgkQEg2wmwP4 2IYWRQ//aIc6OlvzwY/3OYm95qKK3O9I3xVTq6/u0IgD+BY+MhMTXx/Ba2jruGZE MKeLrRObyS9V8gfbLgDAbuajI+UIBuIszVdm1YqXy3EfPAZQXWWB+W+pJDPgQzvQ zFNFrV6cQTYjVqkiUgD3/OX1pVoAesR7xlBdi+gTj7hGI7TmZ48qRzezz2MLmEX1 OZddhbmfXfPlFDH0hrFhlugROQbEpH4iZlI5J+vp8XPrWKIYD9alvTmTbH1iyrss okQB3xet16ZyR+dft2s2+Bwa7t+bKVltAdAHFeNR5GuCghhPAoCt+N2OzFRxLa8m zIRvcSLyZ8xCpElHS6nybeeXfRjj7sUUVPwOpcH5UO0T9SnqhBA42C3reA36mCwl PT3YAwWGtFUsuPUt1C7lmsIJYIMB8wWXlSqnOkbY6BzUl1E0xRNCdeAFllUXk/Q3 bOTwtk5IcsDMiN9xQjbmvu0XEf8g6KRSM5pfsEucKScpyqB+XWTucFX3r6koTWbc 0otRMq/5wmzjcaCOAJHimGl+BHOldYy+EeP0nqTL1pxroLnkVHOAzqBhX/aBwDPF 0aGSbZOKeetteadb4riEoF+mBHaUg0/YT5u0Wox+9hL7e/9wVqCRLUpL8bZjNC9Z ZBJHuMOfA4K0bTMJxxNbg9BARjH5rxe+c3k1Dak8XJpVmHpz9yk= =Ozjo -----END PGP SIGNATURE----- --=_a697ab9abdd776089dd8896cad57a970--