From nobody Sun Mar 10 05:23:05 2024 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TspGL6mwzz5DH4B for ; Sun, 10 Mar 2024 05:23:22 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic317-22.consmr.mail.gq1.yahoo.com (sonic317-22.consmr.mail.gq1.yahoo.com [98.137.66.148]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4TspGL03D4z43Fd for ; Sun, 10 Mar 2024 05:23:21 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=nm+rjizT; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.66.148 as permitted sender) smtp.mailfrom=marklmi@yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1710048199; bh=ayIgCVb5/sS1RzsV3lDbbOfSOgFdbnD2fTMYAc2d92c=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=nm+rjizTSJdEu3E9bjpqNo8Zxs7r+iMq9blRqnZZZQAE4DPf7bZmLOgnegiwxBhj/noLVDvR0FNF7kN0clTcMm24vhY4e7Ja99hh3jv2MjRjXhR1G7eFkNH6XKNrbc3I0F8lBSiMSHd92jNd0ayI5JqG0p6LhkeT/7lDD1fv/SBS6DPr6KWLlvSauwLRStmErA+n99FmE94bwfDrSMdrxcpVq7gPr8Ga/wHineJKfQQjqXi30UQxUyDV0KrqDeq1cTAxSprZ3+lApbRDay50xw+MwdYBorvC1GpdBqUdaYoMYtr3qVSndLQjsl4Ca3vCTUPlbyusyIK3O3ynH32hYA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1710048199; bh=AqXUNla6QFpeuGeOsCgXAdmA+ScpvpeJtHr1/djq8Nn=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=ZZujDL3brQDAdDW5FlVj6Bgdk8+af0muHIVirmPfkvpJHow2/GwRWrLUBYkmzfjFY40fsQpFiOepbhFvg8O8WrVqr+bgr/etKq6LnSXTToQMGkck76DzZgV0TQpQE8OI/utoBe7MWoF3ISyApukisLwyCjURD54OPa5nFEeJ1Z60f3bLUQVRkuHc9oAgtMIaNZIaJjNn6aPMTym6Cz866XWgtilqjKZunFYT3Wl1ZG6drympOmZNzY10PrWvZV4sNfESUuwiZCLF4ObIvrIIR1ljUslH5bKR7QKskq14gusICTgCirUHPy9tNI1yYCd05bOGSzR4ZdSKZkARZijjQw== X-YMail-OSG: vbWxlxgVM1ns_KuBwqqLUXHsN.3.mCSXW7.KeBC5dSQnVxxl.l_YmvrWiMJlDt9 LjG8rVJAA9GKFqBPr.uTOct.MmvLTqEni0FH5XPsk35yfrzng48gRJ2U2bqp120898zt64KmViaD 1lbRjpty4GRDyHUB3TjqtMCPgNKMkQoLVdA5R2P3ELrLSPxaWVoiJtmOQNtEkS.q2_eZccjjjWfF w.QHQlF04k5ypf9WvEnd8RAT.js8TXSogN6_dWG6aC6qtBCayza5OTNK4zKpomjyxAeBPmxXvLx_ z_qxIOFylodkpiyiHTvH3SGZ8VHPrWhgBAZ15CKCpz2qF1Au.Bi_7lXbzdOEBAQOukIddVjjPz4F e.zICUFC6GGemAOoecne.cvU5lMXAhSu42UmMCPFWlGpfu3XY.HzaQOXFKDhscibVRfH.W_lVLJA qhHQ3VY8N0Mux3fUEOq0NOJRDrRSGNbNWaBoG_qF1QAXRV8lpCFnG31H2chFH0MD4nAyBYzBQrss sByjjQ3xiNr5mrHOE.6FDhnVwnfsqz7mHnV9BzIHE5AE9opM77T2u2j_3hWxoMqB.nPD9jS6XgnN ShgWhhUzoEl_hdtauOGRZHY2pLP1HA0Xh7CptcnqGi2VBdJr0wD_CBsyxQOlF5yFTM5CNPw.WF4L 0PgdInmW.f_SIq0R4TpUAjPsBC72PCW9tADtGZoCFzchoyPde29ANzKd.KN9soAt68xNkgnYYx4z LFasFGdbl24Y3JgX9dvM0F6FyKyG8nCKM0TBiHGqh2wPDWHY1ajfNF_6508Y8dVYnTh1xrJLEiOz oAXkWHS_5.5FK1stGOjsHgF2S6grBCAGLk8xSTSdSD_Yi0tjBVcd2E.lRbRZvkSC.8JQLFDDPcbi bBjiHsOaQm5QsqgdAtTzBkAm_vPA2pp.WZWsKL34ZpORLdZtxdKwZSlo0ezgDUfRXLxwSPAgZ.We eYhkwJrJs0peOvzqeEsEb8mEfr_e4eQ9_eeVIK13zxuyFPvO9fpHWKalfF3kyzGyLS_PiajVxQyR okVg0tqwlv7WqhYJF9Q27FeQXCqirbBGlwy27bnL9s01_ORN5JU6ZQLExvvnpYYe6FvomQmE7BZ0 696r5Jmy7l9IkbyuwX08Svubzr2APw5VCZH8BDNH5mLuy.lYt2BhPKjl26p4AVj5fZQyK8_zr.z5 ELaKTErD86NfwOS4aD.0UodQF.iHwaOfKkeWQU8MycVChWASBG2D6_47Dcig88et7MH1dgC145Uf f5CxpJZXGdU8s83b9X9L3eTm.dIrNW4fl_n7Xwaf7tlf7fVxt3iv3DWujQAnRWSH1lhHZWKk9WyC MEqx9L4cd2LDHruAsRWadglWSGWbGBbbP36w0NHMNk2yy7Mv8uRX.K9RlZLtZGpdcielpf5eFVn0 yqoueftruClUCdTmNHaQS28kfQXLgFOojEoQYcplHW4HtKc6ifYVvSuPJECqv0cYf_k8uR5k._70 Aa01RaTsRtfbi9zIWVe7kjnLzXmfq_Sw6maHHmpnK8NkPJ0MybGZDSxp8GNDJOclQ5UIGzTWWtEC 4RTv8sIIvIpgHymlxJNmC7yUyMNSnWyjZ5KawaDjVBX9yL4Pq0tNbomuRPS4Vn.cEaKqM48V9A75 nnG2DOndi.xci.wMjj9GOBVkzDXHQyPFpLDsPr4FOf5HzgFuwKiAb2ZbY1w0XJnnE8HUUkroPqX. 0iCsEV4cS5JWGOovPUZIjfJusDN5O6q0Vih5hkY0Pk9il.5il0tOhrSFavwK8DqSaDovNTUiqz.N 45CQsp.VYLxKWYyg.vCi41Q2KDoQPl3vovIxrPeeU3KcdEvd.toHpNGhJqUrjW7cEdvv7b_eid3k xF8ibMO5yHN.rwWr_gfWLjfkvZgJ5gZ_982gMZNojxsTAccWDWJuP_buOSnZPsmFDYvPMeZ98zOh deLZs9HVhapSkuVCXxYMF_IETEMhBjDqAd2S3zgE_FQb1m.ZY3yP3rGDLvQLhV_69DBHmxJYJlX8 .Yrf_Br6tIqdmCS4civrqrRpIjp48ZSg0Oqel9o2fEfq6YFMgRRz8d12pDhIhYbAde3sNKWVzwEC JdJFOvFXxv8KDZzNOY9IoQsIPH8Vk.urQNH1tOX5IREffxToQrgNyMu1nqeH5ZJFVdv8quQ4h2F5 HMDfIQeKBFWlMoiHoRASEJ2MdIOW72JN4vLmsQhgtOe8oURzN__5rIw4IdrgWlVxh59JDtom3Ds. Ha6kfJzqzdDhHqIoczbPHrPJ4hW5Lfkn_GYYLQqbqEQaa41T.NlXflg-- X-Sonic-MF: X-Sonic-ID: 716bc353-8837-4f43-b559-fa3791b1ec13 Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Sun, 10 Mar 2024 05:23:19 +0000 Received: by hermes--production-gq1-5c57879fdf-6xjwd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 18ecc9f8bf17ae4ad9d89e65ba101bbf; Sun, 10 Mar 2024 05:23:15 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\)) Subject: Header inclusion question(s), for example use of cpusetid_t vs/ explicit inclusion of sys/types.h Message-Id: <6D583EFB-BD79-49F9-BCA9-AB22DA77DFB8@yahoo.com> Date: Sat, 9 Mar 2024 21:23:05 -0800 To: freebsd-hackers X-Mailer: Apple Mail (2.3774.400.31) References: <6D583EFB-BD79-49F9-BCA9-AB22DA77DFB8.ref@yahoo.com> X-Spamd-Bar: --- X-Spamd-Result: default: False [-4.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RCPT_COUNT_ONE(0.00)[1]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.66.148:from]; APPLE_MAILER_COMMON(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.66.148:from] X-Rspamd-Queue-Id: 4TspGL03D4z43Fd FYI: /usr/include/sys/types.h:typedef __cpusetid_t cpusetid_t; I've been experimenting with clang-tidy (really clang-tidy18 in a llvm17 libc++ context). Its misc-* checks include reporting when the likes of: / . . . : warning: no header providing "cpusetid_t" is directly included = [misc-include-cleaner] In other words, it is suggesting an explicit include: #include // for cpusetid_t no matter if it is indirectly included or not. I'll note that clang_tidy also reports the likes of: / . . . : : warning: included header param.h is not used directly = [misc-include-cleaner] if nothing directly provided in sys/param.h is referenced, in other words, if sys/param.h is at most indirectly causing other files to provide some of what happens to be used in the translation unit. My overall question is: is it generally reasonable to follow the suggestions that would eliminate these shorts of clang-tidy reports? Basically: include just the files that directly provides what happens to be directly used in a transition unit. =3D=3D=3D Mark Millard marklmi at yahoo.com