From nobody Tue May 02 19:25:12 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q9qm16pKyz49KCp; Tue, 2 May 2023 19:25:05 +0000 (UTC) (envelope-from rob.fx907@gmail.com) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q9qm11hsFz44sC; Tue, 2 May 2023 19:25:05 +0000 (UTC) (envelope-from rob.fx907@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9594916df23so130493866b.1; Tue, 02 May 2023 12:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683055503; x=1685647503; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LiOIjWmt1NbUmkN9IZ2lHw/4SCRlFTaji52oJE1sx90=; b=MDpEZB2P791/Y+7EPZF+FcImymz5gvGq5hQPaXTGOvD2KrlmFnGAiYyuaVzkiwwpCc OFiwedgo3l4oA3PVAXWPirsAbJtdzwymSrN2ZgR89dNxMDp0xseHNjyRmk33G82y4TrN 5vYsCwisrI1b9j8s4Pb7z9iq0HTov8DpCoezJ9hCmQx3hsIOKiHGjOkVJTBoSFEuo79y if+ffpbW7awlNVjdEdXwR9zu1UJgHciD8SxQC1aPgFRvgv+W1v+eIWwUNPfc1zr+WsZb 5CS2bVSD/Y9v7zMXAAjWVChsV5/BMZOkzb5J9s/MCeL+FA/ll/MBcHXDzkvOCcp7VcdR Jdww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683055503; x=1685647503; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LiOIjWmt1NbUmkN9IZ2lHw/4SCRlFTaji52oJE1sx90=; b=Ux1lEikvmsMv3xX+yFR+0wxKocy/ur0taVbNk/tF1T/ozlMF6/YDp++xmJXC67znBs LpTP3yDfXNJucrmBNPugT/9SfqNtxNAeOwppHctGoY5DJ3lTgweLTJzgz6eqG2FjiLJo xajW7aBhmD1BVQuWhhKaGxZA/Ru93tVj8hoGjFPugCX/aeRBwd+iI6hHTmK2T5z88kEb MixJHCdTTshOjVoQNgxr8C6uB5zMFVhWWeFe5WPUVgZzjgjQN1r5O0hU6TJ+anDk3YZZ hUxXhodADL9ERIlyf4kvApTtnd3KJxbwlb5nKt8jT0fKiy4NnGr8jQfeXLjmovH+vGhf nOoA== X-Gm-Message-State: AC+VfDxx1RrWsA/7lMNHV7lZqNQ7FxRsC0S5IYRknLvJP/Wq+I+O9dbB og/7mBewDfqwoC85Z8GMJMzfZdKrUmQFhtKDwyEy0MJFqHo= X-Google-Smtp-Source: ACHHUZ7AEZ/Ks403S5obdFn8aj7AsOxHE/74/xdMWWVcwHjtYRzFUWGXczp/1bRnaO6yM6mrbzdsqYETFJBRyr6zYY0= X-Received: by 2002:a17:906:7a01:b0:94f:66af:b1f7 with SMTP id d1-20020a1709067a0100b0094f66afb1f7mr2938797ejo.1.1683055503301; Tue, 02 May 2023 12:25:03 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: <89c84bd7-a925-02f4-acbe-12c3000e7007@shrew.net> In-Reply-To: <89c84bd7-a925-02f4-acbe-12c3000e7007@shrew.net> From: Rob Wing Date: Tue, 2 May 2023 11:25:12 -0800 Message-ID: Subject: Re: BHYVE_SNAPSHOT To: Matthew Grooms Cc: freebsd-hackers@freebsd.org, freebsd-virtualization@freebsd.org, elenamihailescu22@gmail.com, Mihai Carabas , gusev.vitaliy@gmail.com Content-Type: multipart/alternative; boundary="0000000000006964a805fabae503" X-Rspamd-Queue-Id: 4Q9qm11hsFz44sC X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_RCPT(0.00)[]; TAGGED_FROM(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --0000000000006964a805fabae503 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, May 1, 2023 at 10:16=E2=80=AFPM Matthew Grooms = wrote: > Yup. See above. I appreciate your input, but the goal of live migration > was set in 2016 with a prototype first demonstrated in 2018. How long do > you suggest a developer wait without review feedback before moving forwar= d > out of tree? > Yea..I'd say a submitter should receive feedback within a week (or so) and when that passes, try rattling the cage of relevant developers to ack a timeline. My comments for the live/warm migration review is to rebase it after the snapshot feature is compiled in by default. > Yup. That approach was attempted with the Warm Migration patches. From > slide 17 in Elena's presentation: > > First review opened in 2021: https://reviews.freebsd.org/D28270 > 5 reviews from 2022 starting with https://reviews.freebsd.org/D34717 > (same feature split in multiple parts) > I understand that, as a submitter, this is frustrating - to spend a non-trivial amount of time preparing/submitting a review and then receive no feedback, not even a "changes too big" or "nope". For future reference, if UPB does another project - might be worth trying to seek out a FreeBSD mentor that could guide the students and be willing to usher the changes in, not unlike a GSOC project. --0000000000006964a805fabae503 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Mon, May 1,= 2023 at 10:16=E2=80=AFPM Matthew Grooms <mgrooms@shrew.net> wrote:

= Yup. See above. I appreciate your input, but the goal of live migration was set in 2016 with a prototype first demonstrated in 2018. How long do you suggest a developer wait without review feedback before moving forward out of tree?


Yea..I'd say a submitter should receive feedback w= ithin a week (or so) and when that passes, try rattling the cage of relevan= t developers to ack a timeline. My comments for the live/warm migration rev= iew is to rebase it after the snapshot feature is compiled in by default.
=C2=A0
=

=20

Yup. That approach was attempted with the Warm Migration patches. From slide 17 in Elena's presentation:

First review opened in 2021: https://reviews.freebsd.org/D28270
5 reviews from 2022 starting with http= s://reviews.freebsd.org/D34717 (same feature split in multiple parts)


<= /div>
I understand that, as a submitter, this is frustrating - to spend= a non-trivial amount of time preparing/submitting a review and then receiv= e no feedback, not even a "changes too big" or "nope".<= /div>

For future reference, if UPB does another project = - might be worth trying to seek out a FreeBSD mentor that could guide the s= tudents and be willing to usher the changes in, not unlike a GSOC project.<= br>
--0000000000006964a805fabae503--