From nobody Mon Feb 13 22:01:29 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFywv4047z3qS9k for ; Mon, 13 Feb 2023 22:01:51 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic306-21.consmr.mail.gq1.yahoo.com (sonic306-21.consmr.mail.gq1.yahoo.com [98.137.68.84]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFywv0mXcz4lGK for ; Mon, 13 Feb 2023 22:01:51 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676325707; bh=OpieL/EShaJUbh3Q5/pfK6mZOQWGJkO7KRfWzikhR40=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=mnegLAshSvYOAGUSlY3kwz0iiGyvZ/ufTnZo59F3CP6v18MpBbrg1025JhHFDnBp/vNhEq0uJM6rMLMBrcrLUb2QlFozYZ1tR17bHW533rixVezf4LlCVz256MBXeWOreZ2MnFYPXwTwP4VisZIH1D+/jUuk1HLXMuTRzbZYRaCmYG6tBBhYikP2QcCz4aRmn/n1MjoIXJA3bNFSOcI7h8ljPXbMg0gczwHzCSfWVySfO3zLjU1QWbbTHm3CZl1fRgqb8etf583ZprvymeyB+DD2CCMvR9nIz95pNweHHKDccfTxk1kRIHZJFaUiMYgGMfg0Eas7qvaG8IoWkPNw7g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676325707; bh=nC7XZuQxcRYq3DWx11zXgryzBReOT7DOBpdq10e9iFY=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=h7nCBtIS+hXCef/QGvBiWfDNAmg13GJcuGQLVEUgZk2O/2pTlA7eJwUrVq+bQ1pLon//O4DNz6ceoucDHUgIO2qDVBaULk94QwSrwdXvDBwWnjiyJT8W6aPdJCd51zFaF0mZ/JmU6epzTCwxbz2CqUchHwniMd83ktx2/LcoRAqd21t//qJtCD+SAgBCCd8kRpbfVs2tzYuYpg+bZgIaybBoRN6m1u+DzXskFsNbqYxceDQID69w5JEuGnvFYnimrsly/w5u/MG9KLWnZGv2Bp7RMKnIOxDLUFCHzQ6vQmyCIw3YOrvM7MaueQhFqv3DXknS5lgiplTPphaSdOXEuw== X-YMail-OSG: 6tCS7rgVM1nTc2erlsYKeP454Pl2Hxfm8qIgmfTUbD8Y.U6wOKYH37hTAHIIcyC kDGbTaeBWTv93x7tpTFiQY2Tj.McPvxujVo2ZhKPbA.JwgA3hxYhjMFo0KyH_5w.V_.DCnASh2aT i.JfCV2S76GzcHM0y039PCzTLFnX9R6dhdvHWujDrQEPeFFW0fC_M9wI1S83Ft.CVbPD0B8GAq9j URsOycXQSShq3lHC8wP0ho9c7JDs5XSAVxHj7KYn9ANz3oH0ZUpz94HEMirvCq0a7KeKLndEl4mX TCUCi.d0BjpPemrw5zRde6GFnZ4aNZy4wR.U4lg076oRu6NVF3MJhD2xqUrVpWBzGH9OoUmsO5UZ aCVTp_dNDXYBWbC7ynBpWNOShpIsIMo2H0LAK_wV_epGb30ZqL6_6wgJzNMFbBLA4OAKel1njpzP FCCmfrHtWpcqx_a445v2d_r9ZG0MLlAfS2Gsu6vx2sdPxy7BYDFYWe4Qk_Eoy1la44mCG.wM8MQ1 VZ7Ld_hbW.MTYm2FU8ohM0qThfi0c5aZ8PVLu3PcjT1Cf1gxNJeg4WJ7A_VIygziZXjxEYtJ15pO 5709wlf_Yf1tPKP4d24eOCS69Q1nWIQk352oRfMPEkBm51j2PnmaHU69K55pSTb6zr7vjalKn9ln sxQVxqYns3UH50z1isQ6O0b8LIWXa31gP7SQdkfxMXwMF65I.hh_TNdDYnulmKJlu3zj9AdOSr6p TiqgAs51tKthc18TUo72XGVy4kw31gjKBJ0h2g0sE8rKy0sqE1HVa4j.avEmP9nJaOFXcnar1wol 5SJLwEpsu6lJQzitvcY1AIno1i6RJj6pW8Vb2U4GedZ.jOnkq2foZxMmJYxTtPAUSN_Eej2O3PQK lQA0xuAeOdR8i7cpDacstc8RD.1faKi_uo7ST9b2XqLwzHnKFmo01.aHu0KVkJRo7mX.Uvhmlg5v YZg6zjEnYdgJ5PW8KnaeRaVp.QtYEIcT2vkunrHMJV2rEUBJjjh.pNvkZ2leYOu5yhwonN9sQQE2 oMIMYhSOYGnNOuMzypYWh1kboSYQVmqYWJYySVTynWUtRkvk3WZjMpKX.rlRHLXZbqXzwnDoEz.I YlPtRGgzqgJpDdNbU6awIIt7FkakxsFuh1h2bIomDqZXKyMAMOst6HSPDpgfu3ardddSbuHsrgZE jZr17lGVTV7R2517R4Qwf6EJd4yqzM6BAa.FNHjfd1mGyDfoWyyfs1MaUQeGmV.z4EClUBrvOS9Y y08VB9c.03Tv.cuDKYWVkbLZkG20ptC0g1jz0fxBrtk3fdWdoivvBOXh1SBZhS98npk9OWifhtFj OMk1C21FJBYjmzFPWt.qMKrBeSPPUAWLuH41AVhGYl4uPXCvJJ0AW8kCHhs5RCIwYE8odvnnYbeP JhZli0oST5h.gEui.lJq0asl5U6tNpHb5Ovdz.lPdX.eNwytJMKdLPM.CI0QJMnINF3rcAzCgDNK eGFhfzjAiljsZk1PsQhKfMOX38zyXiZUTYUgWWAhzyUhIa8MhkmRi1vwnoXJH9D98dikEta8Z83g WRDi1qq4on1k3m3jMfVedGvvz3.8MaRgTJh.kpULKdQAASQmu58AVyQgoF03wy3fy.gMUirESqXT Lcn_SjXniXH0b5omo6NBAJ2zq1haRznBlm.ko0JB.f3LGXekhFWD6BnEHBtjXsB9Km67wDRI31_0 QHi3HwwJ12Lwlj.uF_CIutxtWKTTOBYyNPAnmTpeRdZgR7eD6cCal6koDa9_2TzmCa5.xUdKFn7a xoew_.v2wJy6aZUMdA0aGS8L4Hl.nTfEGVXgkKKRnbinn0yinJZb3RKyc0Wt9tA6p0gbU8C6Kt3_ yoPKSeuRKrIqcuZTusHmviCdLnq7_njXpWYwmu6U9I6yDO4w8oRLht_M0vflgix9OcaeaY1Lijyi 59uOYTwkKJ3iKgVOFZJgCKEKkDyWX0U6wDRtd9xjq65NqB7eLciOHZZ84Ga0cgvPKry9fRmQGLGp isVi2IgAlnSvqFqg6ztbT6yOJW5uJ_LZ6O6D4DtN3Xsiu9rcbSTzXVw3HFR8SO6w6gO.9lZ3AtIl PfBK5ujOB9BQyW0.5U3dQ1wDgnyp4a9LLe8SUwkLfM7oHcW0S7hyEVh_PA1jFZ.mcNT7QtGu._Eh W0zowHKIKAUASL0yEmb_XxG2iz5EY1JHlOrlRcRXjRuHayhTSau8aWfcreH_E1CcojnJbN1nNari YyCmvdGCSu9VoHwq1jV7HCJSCngqJFwxhUJ61tpJsX7ntI4Pb6eS8qRlgzsy4vyDth..8ytZ6qfX aMfXP X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Mon, 13 Feb 2023 22:01:47 +0000 Received: by hermes--production-bf1-57c96c66f6-p9vmd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID dfb1070ddad82091d5acb5947a2b91de; Mon, 13 Feb 2023 22:01:42 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: CFT: snmalloc as libc malloc [snmalloc misidentifies what llvm versions have source_location: need >= 16, not 15] From: Mark Millard In-Reply-To: Date: Mon, 13 Feb 2023 14:01:29 -0800 Cc: Shawn Webb , FreeBSD Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <6660BD19-13BA-4F73-9447-A3B54D8E0B29@yahoo.com> References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> <20230212222456.2vcvgf6v45na7jb2@mutt-hbsd> <16E1DFAE-B679-4E10-9139-51336F5306AF@yahoo.com> <9AA79B35-51E6-4FA1-BC41-E51CDB819D2D@yahoo.com> To: David Chisnall X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Rspamd-Queue-Id: 4PFywv0mXcz4lGK X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Feb 13, 2023, at 02:43, David Chisnall wrote: > On 12/02/2023 22:53, Mark Millard wrote: >> [snmalloc misidentifies what llvm versions have source_location .] >=20 > Thanks, I thought snmalloc included the code I wrote in a related = project to do this, but apparently not. I've opened a PR to fix it and = will merge once it passes CI, then bump the submodule: >=20 > https://github.com/microsoft/snmalloc/pull/591 >=20 For the: -#if (defined(__GNUC__) && !defined(__clang__) && __GNUC__ >=3D 11) || \ - (defined(__clang__) && __clang_major__ >=3D 15) +#ifdef __cpp_lib_source_location My understanding is that __cpp_lib_source_location is guaranteed to potentially become defined basically only 2 ways: A) inclusion of B) inclusion of Clearly (A) is not the case here and would require a __has_include() test to allow this style of attempting to get a definition for __cpp_lib_source_location . I looked a round some and did not notice an example of (B), but I may have missed it. So, it might be that this changed turned off use of in unintended places. =3D=3D=3D Mark Millard marklmi at yahoo.com