From nobody Thu Feb 09 19:45:51 2023
X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PCS5x5VPVz3nW97
	for <freebsd-hackers@mlmmj.nyi.freebsd.org>; Thu,  9 Feb 2023 19:45:57 +0000 (UTC)
	(envelope-from brooks@spindle.one-eyed-alien.net)
Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4PCS5x3XXsz3p2s;
	Thu,  9 Feb 2023 19:45:57 +0000 (UTC)
	(envelope-from brooks@spindle.one-eyed-alien.net)
Authentication-Results: mx1.freebsd.org;
	none
Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001)
	id 3AFF63C0199; Thu,  9 Feb 2023 19:45:51 +0000 (UTC)
Date: Thu, 9 Feb 2023 19:45:51 +0000
From: Brooks Davis <brooks@freebsd.org>
To: David Chisnall <theraven@freebsd.org>
Cc: Mateusz Guzik <mjguzik@gmail.com>,
	freebsd-hackers <freebsd-hackers@freebsd.org>
Subject: Re: CFT: snmalloc as libc malloc
Message-ID: <Y+VNbyqkMGKtbGVi@spindle.one-eyed-alien.net>
References: <2f3dcda0-5135-290a-2dff-683b2e9fe271@FreeBSD.org>
 <CAGudoHFYMLk6EDrSxLiWFNBoYyTKXfHLAUhZC+RF4eUE-rip8Q@mail.gmail.com>
 <E140A3A2-5C4A-4458-B365-AD693AB853E8@FreeBSD.org>
List-Id: Technical discussions relating to FreeBSD <freebsd-hackers.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-hackers
List-Help: <mailto:freebsd-hackers+help@freebsd.org>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Subscribe: <mailto:freebsd-hackers+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-hackers+unsubscribe@freebsd.org>
Sender: owner-freebsd-hackers@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <E140A3A2-5C4A-4458-B365-AD693AB853E8@FreeBSD.org>
X-Rspamd-Queue-Id: 4PCS5x3XXsz3p2s
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-ThisMailContainsUnwantedMimeParts: N

On Thu, Feb 09, 2023 at 07:36:48PM +0000, David Chisnall wrote:
> On 9 Feb 2023, at 19:15, Mateusz Guzik <mjguzik@gmail.com> wrote:
> >=20
> > it fails to build for me:
> >=20
> > /usr/src/lib/libc/stdlib/snmalloc/malloc.cc:35:10: fatal error:
> > 'override/jemalloc_compat.cc' file not found
> > #include "override/jemalloc_compat.cc"
> >         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> > --- malloc.o ---
> > *** [malloc.o] Error code 1
> >=20
> > make[4]: stopped in /usr/src/lib/libc
> > /usr/src/lib/libc/stdlib/snmalloc/memcpy.cc:25:10: fatal error:
> > 'global/memcpy.h' file not found
> > #include <global/memcpy.h>
> >         ^~~~~~~~~~~~~~~~~
> > 1 error generated.
> > --- memcpy.o ---
> > *** [memcpy.o] Error code 1
>=20
> This looks as if you haven???t got the submodule?  Is there anything in c=
ontrib/snmalloc?

I'd suggest adding a Makefile check for contrib/snmalloc/LICENSE or
the like with an .error with appropriate git submodule commands.

-- Brooks