From nobody Sun May 29 13:54:56 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B15831B3FAF6 for ; Sun, 29 May 2022 13:55:05 +0000 (UTC) (envelope-from crb@chrisbowman.com) Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LB0RD5HrJz3hML for ; Sun, 29 May 2022 13:55:04 +0000 (UTC) (envelope-from crb@chrisbowman.com) Received: by mail-pl1-x629.google.com with SMTP id q4so8105166plr.11 for ; Sun, 29 May 2022 06:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisbowman-com.20210112.gappssmtp.com; s=20210112; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=MiB/UM5318Jaf0qbjelbdNO6oKvHj28fIbXvrhWervQ=; b=jXkw9LjqulvIsQdTARZImUt/qto7UaLoxkKHaOhGPqUoKviBbM3mrAGCH0X89bRw4Q Parv6PKX2v4fXIW7gGnQ0Utvz54JULXHJWY55UnbulQGSFbJEZPEtwVa4HVordqGqoG7 AzlnbvH/8tB6N0foUZ5Je16MR0G9miKRlri+b5UFhIS4/eyWqYIbAFFZjA+vm2IKRjQ6 YOggdzoQy9gzZtl7FV8wCfX0IL8roLaXsXTRH+2kkFbJgL6JSZJDYYEt7qPTd8Vb6ZOf KpE3OMFOuz0yurrli4vfumfHJjcWVxtwgt9jvkQmgQoqE5Xkk25jFpoadFuB9whmNlqF Q51A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=MiB/UM5318Jaf0qbjelbdNO6oKvHj28fIbXvrhWervQ=; b=tS43V6SrqnS6onC5CCCxX6Q9Y+FLsiPJAnyLBMq3b1nt8WrERVnJI84Uw6bXlSKOHV rZs6mdqXMDTRUID3O69WBzf00FzkrQvwfSu7ahJMG4G65DUmy93OvmRZjXYk2vLyFgG/ fRBc6fn14FM57pAALLwrotx5xftkASB9MwePIeRtr2kzYHRCalwFNgFy9jkMgjkzj1vg Aw16xYZ2tN0FV83mM8z0EMjcZGRSF5MeGHYxCKbggJyo4NSA5YRvqmZqTr6QZyr0JLWG 4U1PAHvnHtKgpuIMFK53ZvYpWxH38ddviX77Lb3tQX1AM36iqJYAxiz2HN3IffnOk4bA fN/g== X-Gm-Message-State: AOAM530Xevqbk5OVbH+zOGWheYmNDOoGvsj3Ln1sDp83eyTK3JMhBVMi 3wdICeG5GokZIIh49PE6ALJgOlP5ft7SJmN9 X-Google-Smtp-Source: ABdhPJxCHUvSSJ3G6bAY5bHHdx6WHAWjHZlVe5B/ozkroWLYhnaJRjWRD2XwYfsWgtw0t4uzxfog5w== X-Received: by 2002:a17:902:ee54:b0:163:bdf4:1112 with SMTP id 20-20020a170902ee5400b00163bdf41112mr5555846plo.89.1653832497929; Sun, 29 May 2022 06:54:57 -0700 (PDT) Received: from smtpclient.apple ([2600:1700:5430:10b1:2c4c:3814:f89d:eb4f]) by smtp.gmail.com with ESMTPSA id 13-20020a170902e9cd00b0015f309f14d0sm1117807plk.56.2022.05.29.06.54.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 May 2022 06:54:57 -0700 (PDT) From: Christopher Bowman Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\)) Subject: putchar in boot1.c adds extra blank lines on Xilinx ZYNQ board with U-boot 2020.04 Message-Id: <3D090089-F20B-4B5D-A589-391E6536A875@chrisbowman.com> Date: Sun, 29 May 2022 06:54:56 -0700 To: freebsd-hackers@freebsd.org X-Mailer: Apple Mail (2.3693.60.0.1.1) X-Rspamd-Queue-Id: 4LB0RD5HrJz3hML X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=chrisbowman-com.20210112.gappssmtp.com header.s=20210112 header.b=jXkw9Ljq; dmarc=none; spf=none (mx1.freebsd.org: domain of crb@chrisbowman.com has no SPF policy when checking 2607:f8b0:4864:20::629) smtp.mailfrom=crb@chrisbowman.com X-Spamd-Result: default: False [-1.66 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[chrisbowman-com.20210112.gappssmtp.com:s=20210112]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-0.999]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[chrisbowman.com]; NEURAL_SPAM_SHORT(0.14)[0.143]; DKIM_TRACE(0.00)[chrisbowman-com.20210112.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::629:from]; MLMMJ_DEST(0.00)[freebsd-hackers]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Looking at /usr/src/stand/efi/boot1/boot1.c The bottom of the file has: void putchar(int c) { CHAR16 buf[2]; if (c =3D=3D '\n') { buf[0] =3D '\r'; buf[1] =3D 0; ST->ConOut->OutputString(ST->ConOut, buf); } buf[0] =3D c; buf[1] =3D 0; ST->ConOut->OutputString(ST->ConOut, buf); } On my platform this results in an extra blank line after each new line. I=E2=80=99m running on a Xilinx ZYNQ board with U-boot 2020.04. Does this blank line show on other platforms too? If so is this the = desired functionality? Perhaps it=E2=80=99s needed for serial consoles = to work right? I=E2=80=99m running locally with the if statement completely removed and = that fixes the extraneous blank lines I see. Regards, Christopher=