From nobody Thu May 19 16:24:59 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 434F61B46580 for ; Thu, 19 May 2022 16:25:00 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L3wDr1Mcjz4vP9 for ; Thu, 19 May 2022 16:25:00 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652977500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=enkuR+57DmmRMtE67ErVn9ivJZF38L56e07BuZXEW/U=; b=ffeXgLB4Bbv5UTewda2V+7jt2ieDBqbsL4Xp3mY3IL67pnQd7TJ1IwABIOwTe8Vhdf9Vi5 03GntnfWVQN3MFbJP5K3d7gvFRomsLrvgqDHxUooydGVmDCU+oiBbSsPL/tjc8AEsfKPPp lOZCoCpRjCa0FBvuxeXETlbVbZz1gPaTtNm3XILQ2RA15h/j2SLSX+nVgo/JFAXMBQlLDG KAJOAzNH8tSRZEDO9DnGyG0rdZL6fp2QO1NuHiAHeKMDgPqz2n9LOeKDFcvNw1lukSj4Cz 7YgmPFrnxaZqsUQrXcyKIZjoXQlD75i26EkUXEDZsVaLxAtg+JnP1dstYAoV7Q== Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 0B3154D7 for ; Thu, 19 May 2022 16:25:00 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-edeb6c3642so7402020fac.3 for ; Thu, 19 May 2022 09:25:00 -0700 (PDT) X-Gm-Message-State: AOAM530d5y4vBGMH49N2wb8biMlO4fvI3lY8FH7lcQN/XGRio3t062YN 4hl+J38FDi8WdImkWjqFJZLceHfkoEYlYUqVjw4= X-Google-Smtp-Source: ABdhPJyQ+1SUmEUhAkPmo5QEbpJmuG5RAJCSw6egyPhHeAFezTF9JvGBL80rGfyuhinLxuYaMuSv4oWPYWw7qEkglVM= X-Received: by 2002:a05:6870:e248:b0:f1:eb1f:945b with SMTP id d8-20020a056870e24800b000f1eb1f945bmr3012212oac.292.1652977499322; Thu, 19 May 2022 09:24:59 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Kyle Evans Date: Thu, 19 May 2022 09:24:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: iconv changes To: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652977500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=enkuR+57DmmRMtE67ErVn9ivJZF38L56e07BuZXEW/U=; b=QDwqBY0UJRdUWHlK/rIJw+qbdVXp/WBtnimgoYh+9RDljx9f0SoGHUG/xG0MJUZFfDSgem ToJodKPjTo+8NvZm4xKv2yXryUGGw6XmUoMyOC3yAD+dCORaVYYbjstjx0gQ+aeoE5SogT hywBX2tW9l4zvfq1vKp3bzUNpDsO5iKfYtiV0pArw85sOPJf0t547w2+ajHjjqcL0x7hZu PEXT6CsPGbMKK1yoSK0EBDsDbhVspRRjYRu9RVOwqZH6jO09kQ3xjtsnWQ7MBYJN0N1CRM H6/LYNyCWHU+RMUYI0rlEM3cJprCCBbG+SmuaHF3ZAB1Nh3zTnxL0T/Yxe3hLg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652977500; a=rsa-sha256; cv=none; b=Ge8YKf3lGvMlCEVQEcrey8ONgwki8Q5ybeC8nK9vfQG1LwFha5fiDeKnoGKIVJ7mzLSkxi yNKN13jBM4S9ku3tu7y0FUXRo8vGRimHdR+w9wroWKWQLUsOYugUnqmv/s6VXIZBGkYhj0 xgztXO1qSNbfwAKjaV+kKsg16QDGev8+t4WeQQxtAwCo03TGGE5WjhutJzkSLhOHPBoO+D ++CmWEO5FmT1dadiL6xedMGyoZiaBWoYU0p97bq1rJpWsUl0Z3OMnPEv83mi3gPgjNxIPn OjStO2D63+ZOziyY+0rGq2F6x/cpHWQSEkdClb2HcHdUOYvDtWhhd2IFlunZdw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, Feb 22, 2022 at 10:34 AM Kyle Evans wrote: > > Hello! > > Results of `git log` were somewhat inconclusive, so I'm casting a bit > of a wider net here; I've got four changes just posted to Phabricator > for iconv and iconv modules that could use some third party review. > These largely pertain to //IGNORE support: > > - https://reviews.freebsd.org/D34342 ("iconv: only conditionally use > ICONV_SET_DISCARD_ILSEQ") > - https://reviews.freebsd.org/D34343 ("libc: iconv: push option > ignore into citrus_iconv_open()") > - https://reviews.freebsd.org/D34344 ("libc: iconv: add mb_cur_min > for encoder traits") > - https://reviews.freebsd.org/D34345 ("iconv_std: complete the > //IGNORE support") > > The short version is that //IGNORE is only partially implemented at > the moment if you consider the behavior it was trying to model: GNU > libiconv. With GNU libiconv, you can use it to, e.g., sanitize a UTF-8 > string by removing illegal sequences rather than truncating. > > These reviews aim to fix it so that it works the same for our > libiconv, which would previously only ignore EILSEQ that arise as a > result of csmapper failures and not those that arise in initial > mbrtowc. > 3-month ping: any takers?