From nobody Mon Apr 25 13:18:08 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9B2341A95DF1 for ; Mon, 25 Apr 2022 13:18:28 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kn5Dg6mspz4m1y for ; Mon, 25 Apr 2022 13:18:27 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-wr1-f48.google.com with SMTP id u3so20843178wrg.3 for ; Mon, 25 Apr 2022 06:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=/GSCGhESrRoLQtcMsc2ysQY4Gha4qtyTagTRBU/4h74=; b=akzFygbgJMXQpFz8Y29HNR0R1GgInb6stIrdCLgO9SdLTMYH37x/8xJMIOXNnsG7Jy dC35XW2EEcTXqorz+CSvTKMm+9o6AdVElPdNb5ZCmZn8uJsltFGGDiIg+UseXp7kGl63 QKirTjdR9eZDOmOqDsv4C5OwQoTFS+OBv1J69Xs1pUvqVGgZSokdWsR/1XSbFlRAwNJz 51fh4Qa7S7RtVibb9QQxZKol6K7fwuZmX9UNSuYmeOatpjp08ca6Wjkymtb8x3Ai/Fmy 9N+BYdqT+80iJgShPPcX/2yliVOz74xjTgjcKyx0jJ83ewnxZPuI94S6JQVf94kZCthq SNTg== X-Gm-Message-State: AOAM531OJ+TkQW+YeCzgz21DiM9bKWF/JMCVF8/o2YQM20ZlkjaEJnZD KVRCBY7roZ4/Q+WUhH0usHQS2SJ/hsX9s1Dc+ElE43Fhm/Y= X-Google-Smtp-Source: ABdhPJyNyKg4B7yUvVjoPU+wQfs4V7I0X85AUCgFLh4zni2+aYBSZinneZuUMSeOs7svYW33Zev0g11Cj3GANxpH1Cw= X-Received: by 2002:adf:dc0f:0:b0:207:9980:5de8 with SMTP id t15-20020adfdc0f000000b0020799805de8mr14149204wri.300.1650892700415; Mon, 25 Apr 2022 06:18:20 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 From: Ed Maste Date: Mon, 25 Apr 2022 09:18:08 -0400 Message-ID: Subject: Retiring ssh client VersionAddendum To: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Kn5Dg6mspz4m1y X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [0.84 / 15.00]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[carpeddiem]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; NEURAL_SPAM_MEDIUM(0.86)[0.857]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.48:from]; NEURAL_SPAM_SHORT(0.98)[0.984]; MLMMJ_DEST(0.00)[freebsd-hackers]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.48:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DOM_EQ_FROM_DOM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N ssh supports a VersionAddendum configuration option to specify text to append to the SSH version string. FreeBSD introduced VersionAddendum for the server as a local change in 2001 in commit 933ca70f8f88 and later extended it to the client in commit 9e2cbe04ff4f. In 2012 upstream added support for server VersionAddendum, in commit 23528816dc10. It is not supported upstream in the client. The argument for supporting this in the client is not nearly as strong as for the server, and I plan to retire this in the client to reduce the scope of our local patch set. This also avoids some cases of conflicts in ssh_config during update, as a user's configuration would typically follow the commented-out default VersionAddendum value. I have a review open to make this change, https://reviews.freebsd.org/D32930.