From nobody Thu Apr 21 15:27:20 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2E9531994541 for ; Thu, 21 Apr 2022 15:27:24 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KkhHH3Fztz3Jg7 for ; Thu, 21 Apr 2022 15:27:23 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x730.google.com with SMTP id 204so3786755qkg.5 for ; Thu, 21 Apr 2022 08:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YENG5fKwExM2OtPoASQ0ogJh7iNWjNqNl9cmBZ4pI1o=; b=euRjtlw4BVhAwEl5XX3C/bDpMkJBIGrLOdsnS6G1HEZkaIPvqTtLj6UtyOcCmsV75D izIZywZmfkR02s5jzqX+CkcpnREOR9zB6jgmBl7UTEgqeX2fKApB4Uc1oSsRlL90S0Zv T6CqWGie61ja32DZrTArzp/Ye6dpBy6vXZBEmavQ/B1Tl72Q1Pm4OORWLzI7XLuojXEZ SQ7onyHJPV4Sx1GCE1PVcZLhKE3fVz89Q3MS2jjhHburugIL68qVUvWb5wxuQqAMoo1B H/ujlcGssxFN/vBg4SVRxHTNOmckliPggrW+BIXMr6uidsShF3o1D9aNRUUvkZ/Ow03u OQUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=YENG5fKwExM2OtPoASQ0ogJh7iNWjNqNl9cmBZ4pI1o=; b=HuYMJWTf48Mq5H7EFcLQohjY2KVB+4jBstNFZ0zGhzl3JHrU7eBkmJ2cR8K8W9AzVV 5Gyr2fJ9W+wU2Q2kgqRwdvJ2ZDx2hr4TDq/WsHIAMBzhVVmZ6J/8GrIVpeXzyd2qsLRq J886ChUG2knLa+djsnADjuADS+xq3picINcZ+tjivnxaHwqg1TjL/R12J1HnGGnMl11s OPnGxDWS9sKB7z1QyyD2mWwoONDQKwxmD2k5492ceCBlKB7ST+Qw24UPFSwqh8m/zJnm zBcazmBpxsC747ceekLtUvsxJZcddY00/+xf/1Ks+JVpeGLQ/siC4fd6cbmTOwYjMX3n k05Q== X-Gm-Message-State: AOAM530kUg+XhKLgIviDvVpoSuSnM3BAM+mgaswUvUES2xU8tmyKWlF4 LNiUJR8njOAYzX9CSUUR2+jS8Hheznk= X-Google-Smtp-Source: ABdhPJxxQkP6VFBkr6MsM7N4Y1nAy8Gjk1IeHcW61hLxPydQ2xFHlVQ2z1M6Y7F8AnC1eldA6/TMQw== X-Received: by 2002:a05:620a:24ca:b0:69e:c8ac:ac16 with SMTP id m10-20020a05620a24ca00b0069ec8acac16mr7545152qkn.89.1650554842992; Thu, 21 Apr 2022 08:27:22 -0700 (PDT) Received: from nuc (198-84-189-58.cpe.teksavvy.com. [198.84.189.58]) by smtp.gmail.com with ESMTPSA id b9-20020a05620a0f8900b0069e84c5352asm2909185qkn.47.2022.04.21.08.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 08:27:22 -0700 (PDT) Date: Thu, 21 Apr 2022 11:27:20 -0400 From: Mark Johnston To: stephane rochoy Cc: FreeBSD Hackers Subject: Re: vwarn: libc vs opensolaris/ctf/tools Message-ID: References: <874k2mzf8t.fsf@stormshield.eu> <8735i6zdpy.fsf@stormshield.eu> List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8735i6zdpy.fsf@stormshield.eu> X-Rspamd-Queue-Id: 4KkhHH3Fztz3Jg7 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=euRjtlw4; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::730 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [0.69 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.99)[-0.992]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; NEURAL_SPAM_MEDIUM(0.80)[0.801]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.58)[0.577]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::730:from]; MLMMJ_DEST(0.00)[freebsd-hackers]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Thu, Apr 21, 2022 at 04:57:13PM +0200, stephane rochoy wrote: > > Mark Johnston writes: > > > On Thu, Apr 21, 2022 at 04:24:18PM +0200, stephane rochoy wrote: > >> The vwarn function seems to be defined both in > >> lib/libc/gen/err.c > >> and in cddl/contrib/opensolaris/tools/ctf/common/utils.c. It > >> seems > >> to be ok to workaround the problem by enclosing OpenSolaris' > >> implementation in #if 0. > > > > I think that'd be fine. We can remove it outright. > > > > Your build is statically linking ctfdump, due to the use of > > NO_SHARED. > > I can reproduce the failure locally, but as far as I can tell > > the > > problem has been there for a long time. > > Ok, got it. Fixed in main now: https://cgit.FreeBSD.org/src/commit/?id=45dd2eaac379e5576f745380260470204c49beac