From nobody Mon Apr 11 17:07:04 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 02841CFFCF8 for ; Mon, 11 Apr 2022 17:07:18 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KcZz96gDNz4gPR for ; Mon, 11 Apr 2022 17:07:17 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649696837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5HDSWKLoC9K0EzQSPt2nSmYrp8/P7EJwqhlIu9us3BE=; b=JFXRgOk+/4A2ZC4edMrZ1eKqDSxKytr81FVX9Er9UwnKuc1JEmW80PD7H43wfklgq3bXr2 c1jMfNO+GFKPS/NVDM9SoGV5SkdpptEt6hWaQC7xhu05U05Aykv0hNptAupuWad6WFvJin Re/w1nCr02hLayTbrvLtr4Pad3baTCFMhxZ9i4ek45Sf9SmOWrMGs0Qzy9pF5JUH4+xHPj vEQ4EFsBM3LCbkd2e37OhDQe5aXtIi9sv/flXUs1hqm5FcjxSDkiBRb4G10PMsG9WAAXBi 29Knink2Ojg8EFhByhyq42iNLRXB77FzjEz42q7my07aydF3hRAkeszSydzhrg== Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id BFDBA3E17 for ; Mon, 11 Apr 2022 17:07:17 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f178.google.com with SMTP id r18so5299459ljp.0 for ; Mon, 11 Apr 2022 10:07:17 -0700 (PDT) X-Gm-Message-State: AOAM530Yjly4NePiKGc+UQHr+26xqysK1oiLiTheVPB3RABvva14Kwyt IX91YgJ9+HwRcTFVzgbYeLrzPf3pYOfKc4CN+7Y= X-Google-Smtp-Source: ABdhPJwwytg6UFBUAnXSrRfTw3VHgqc3uuEBDn9QoCMTBEm2pElrUJosF2G50JrHgkxy7z5MaqfC5+DpTGg4Hi8nHOo= X-Received: by 2002:a2e:9e19:0:b0:247:deb7:cd9f with SMTP id e25-20020a2e9e19000000b00247deb7cd9fmr20257869ljk.261.1649696836252; Mon, 11 Apr 2022 10:07:16 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: <202204111658.23BGwmcC073621@gndrsh.dnsmgr.net> In-Reply-To: <202204111658.23BGwmcC073621@gndrsh.dnsmgr.net> From: Kyle Evans Date: Mon, 11 Apr 2022 12:07:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC] patch's default backup behavior To: "Rodney W. Grimes" Cc: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649696837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5HDSWKLoC9K0EzQSPt2nSmYrp8/P7EJwqhlIu9us3BE=; b=TRQAZrlAI38NDXKcWEuMmOr/b/S2lD1bmuwXo/Ed2a7yUMYaRHtJSMX2XII8OopnGFAU0w 4HxILuEMM5vPA1xDEiq1DbxreJWEUIuz2Ml6ILEZJyCK5i3qJPPeHhmFntKgzluIZ3IhQI sfQS+/BZQ6g56uG1BpvBSAQ/bsuNTmrLgoXy5jCPghDfS7xzR4zvsdh5z1LqBDyxl9EQ7R ZaFeB1EkA1jjX9L9GIfZCwIf4LiLY9TfOspckplAQ+Xv8qRujcPfEPs2XD11FM5dZH9fmN EvL3jSSWqyTBSSLs7370wxyNRQwdfcBdX23JC7EVMbw5ZluRC2sG7QLH4bB2ug== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649696837; a=rsa-sha256; cv=none; b=oc1HF8odJnCRKfKt8LBnd1TbzZQqTwDzrOTWWw6KYbF6XAl1QP9YLDUaZ9u1Q95z9sDXCJ CE+0XOABbUCXuC7DhPWueDopoycaQxIR+3J40xjFhzTgPt/UC9BaGNFdO3sVPMA+C3+GDt jkp+SnctOZL7Tzn8bzxg1VMv0WUzTKOOb7OUqjhOPPMHmgUxkX5wXcOvNwOeXYBm8eAaQS Dbei+u5BzVBymfWnYiDIidKRVaefL2zi2rkLwGmhTXCfHEj6nzz1knje9Qj7R9cOqB0krN Rti+pwFTp80lUWe2jTBzTJpRgbFCPd1OeC+XL1B4w84MSSQVLNyEr2XjDlQjxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Mon, Apr 11, 2022 at 11:59 AM Rodney W. Grimes wrote: > > > Am Fri, Apr 08, 2022 at 10:25:08PM -0500 schrieb Kyle Evans: > > > I'd like to test the waters on switching this to the GNU behavior, > > > which feels a whole lot more reasonable. Notably, they'll only create > > > backup files if a mismatch was detected (presumably this means either > > > a hunk needed fuzz or a hunk outright failed). This yields far fewer > > > backup files in the ideal scenario (context entirely matches), while > > > still leaving backup files when it's sensible (base file changed and > > > we might want to regenerate the patch). > > > > > > Thoughts / comments / concerns? > > > > Personally, I'm more often annoyed by the GNU behavior than not. > > Especially when working on pkgsrc, the GNU behavior of > > sometimes-not-creating-backups actually breaks tooling. I also consider > > the rationale somewhat fishy as tools like sed have historically not > > operated in-place. > > Personally, if YOU like the behavior of gnu patch, by all means, > please USE gnu patch. Please do NOT make bsd patch behave in > a different manner simply because you personally like that > other behavior. > > If you want the stuff to look like Linux/GNU by all means, > go RUN linux/gnu!!!! > Your response is completely missing the point, and could have been omitted. Thanks, Kyle Evans