From nobody Sun Apr 10 20:47:38 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A6EF91A8E87E for ; Sun, 10 Apr 2022 20:47:42 +0000 (UTC) (envelope-from joerg@bec.de) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kc3vx4zjqz3PDW for ; Sun, 10 Apr 2022 20:47:41 +0000 (UTC) (envelope-from joerg@bec.de) Received: (Authenticated sender: joerg@bec.de) by mail.gandi.net (Postfix) with ESMTPSA id 64AAF240004 for ; Sun, 10 Apr 2022 20:47:39 +0000 (UTC) Date: Sun, 10 Apr 2022 22:47:38 +0200 From: Joerg Sonnenberger To: freebsd-hackers@freebsd.org Subject: Re: [RFC] patch's default backup behavior Message-ID: Mail-Followup-To: freebsd-hackers@freebsd.org References: List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4Kc3vx4zjqz3PDW X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of joerg@bec.de has no SPF policy when checking 2001:4b98:dc4:8::230) smtp.mailfrom=joerg@bec.de X-Spamd-Result: default: False [-2.11 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.955]; FREEFALL_USER(0.00)[joerg]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[bec.de]; NEURAL_HAM_SHORT(-0.96)[-0.959]; MLMMJ_DEST(0.00)[freebsd-hackers]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:203476, ipnet:2001:4b98:dc4::/48, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[2001:4b98:dc4:8::230:from] X-ThisMailContainsUnwantedMimeParts: N Am Sun, Apr 10, 2022 at 09:43:41AM -0500 schrieb Kyle Evans: > On Sat, Apr 9, 2022 at 8:17 PM Joerg Sonnenberger wrote: > > > > Am Fri, Apr 08, 2022 at 10:25:08PM -0500 schrieb Kyle Evans: > > > I'd like to test the waters on switching this to the GNU behavior, > > > which feels a whole lot more reasonable. Notably, they'll only create > > > backup files if a mismatch was detected (presumably this means either > > > a hunk needed fuzz or a hunk outright failed). This yields far fewer > > > backup files in the ideal scenario (context entirely matches), while > > > still leaving backup files when it's sensible (base file changed and > > > we might want to regenerate the patch). > > > > > > Thoughts / comments / concerns? > > > > Personally, I'm more often annoyed by the GNU behavior than not. > > Especially when working on pkgsrc, the GNU behavior of > > sometimes-not-creating-backups actually breaks tooling. I also consider > > the rationale somewhat fishy as tools like sed have historically not > > operated in-place. > > > > To be clear, when you say 'tooling' here, are you referring to pkgsrc > tooling or random third-party tooling being used as, e.g., build > dependencies? pkgsrc tooling, e.g. managing category/package/patches. Similar questions might exist for FreeBSD ports. Joerg