From nobody Sun Apr 10 15:52:35 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CA3321A89F21; Sun, 10 Apr 2022 15:52:48 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KbxMh5Bc7z3nGQ; Sun, 10 Apr 2022 15:52:48 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649605968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=99XcnMzcRm5b8LiWj7h6PylRwjeEm10jcbTShBSSV78=; b=NvFfN86i3zSUxKTss7I68APY03TNYUB+E+5UTGFHtfWxnkXbFFApX6lKUCK+vkdAKLG0YI niU1ClkrmtRWtmiihznl6rTbzkHT3QCijKyZYWH8au7RL5iq/4QP7LBX0a4aEEnEqOGIBd fXZjvxMSa/RIb1+P4QwuLEYVQr1xkH1m//4rDdbpWn4soXhscn29hH+pzd46ZA7VS8TJXk P+eyGQhvB4iSirmt+qhRimp3vEtvzPfPsK1RDGbgyivCIu3ypIL8fMd9ZoeZmWGov5r4By ppVAj9oHnjJEi9DghBaWCEWVc65X54DtBPK1hrEfuCLlmEY1Y07f2RBzs/Vewg== Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 8A3152628F; Sun, 10 Apr 2022 15:52:48 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f50.google.com with SMTP id x33so16228400lfu.1; Sun, 10 Apr 2022 08:52:48 -0700 (PDT) X-Gm-Message-State: AOAM533CmzueBuePJLlLFPmiZGKG1uis4OQ2muXDmEQX5QEe0TXUVNMx NbQCYL5iQWNSR0GwIxrjfEqQdlhwwfF5Gb8lQYM= X-Google-Smtp-Source: ABdhPJxnziySmo74fixHuIoUnxiXKbemJaTEgnKf+4h++BxcWwOICIWdkEZ95J33eUcUcH9GRVHnuneGUC8nO3Tb8RY= X-Received: by 2002:a05:6512:39c8:b0:46b:9aed:389f with SMTP id k8-20020a05651239c800b0046b9aed389fmr3883046lfu.194.1649605967183; Sun, 10 Apr 2022 08:52:47 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: <9f6f6d16-8e2e-b91d-9ba1-b2cf13270020@gmx.de> <20220410174806.48e53928@ernst.home> In-Reply-To: <20220410174806.48e53928@ernst.home> From: Kyle Evans Date: Sun, 10 Apr 2022 10:52:35 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC] patch's default backup behavior To: Gary Jennejohn Cc: Matthias Andree , freebsd-arch@freebsd.org, FreeBSD Hackers , ports-list freebsd Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649605968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=99XcnMzcRm5b8LiWj7h6PylRwjeEm10jcbTShBSSV78=; b=aB2C4p1J5JUnwcVHLEhDld9ReNq1svngemBKTWnTP2nOVhnHAMwYqyM5shwP3gHRyKIrJw 3q5T5PCSMCuk9QqwLL5DbbCWaTpmOCVFGNK1l1+NfCef+soOsfoWpOkk/YId3NVdkedePq ngOgri96YHInKmhqUnbfzRyyI/MuUlZB3iwrKPlgvu9U4E0gns5YOBpKsMAVvkqY4VmsiO cIoD89gFO68kTXYY6c8iLqM3WzR0eei1odJMqjooAr4XlQV6nACWtTvDPZ/cqjfVi2Cyjt FCWkkwXhEw48PWnSbDFzYam5VHAPl0Bejkd5nZKubCOExeunBiYZ3GMbNaHmgA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649605968; a=rsa-sha256; cv=none; b=UwB61pCQZRIt+89dFGlNIlXeEgFKZ6ym4MT0Tn36kuNS8TWQ+R/dKVu/2kbUIZtWYQwXUN Espt3d6AIsdhDyT9IjXCNnjnMTZ6iqKHma1Y90//u/zvKDYhzFrrfjiaq6kTWWrka5eenj ywp0vroilsh3eQK+m3E7Eo2cPjgwaU8ewWFQRCl1lRRHGyPYC7jv3Gha+Q5pXGjTurjRwY UYn3N2JIVk496Huz1cbPebgUeiYxu5BvHEMi809+svVQgG2I0P+24nkjzAMQuZ+QXzHq66 gwEnz9Tk3I1kuZj8hFQIlaLV7SIB9FVOUJSZGdvs9RakSGc5ZzFhRuGwsp6HDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Sun, Apr 10, 2022 at 10:48 AM Gary Jennejohn wrote: > > On Sun, 10 Apr 2022 10:21:56 -0500 > Kyle Evans wrote: > > > On Sun, Apr 10, 2022 at 5:33 AM Matthias Andree wrote: > [big SNIP] > > > I checked POSIX 2018, apparently the backup files (.orig) are only > > > required if -b is given, so omitting them would seem fine to me, and the > > > rationale section suggests that for consistency with other utilities, > > > the default would be to NOT save .orig file, but the -b option can be > > > used to request them being written (but then consistently on all files > > > not just those without rejects - also because there is no working patch > > > -R for ed-style diffs.). > > > > I'd actually be OK with that, too, to an extent. > > > > Please do not change the behavior of the -b flag! I make patches to > /usr/src/ to eliminate things I don't want compiled in when I run > buildkernel and buildworld and then move the resulting .orig backups > to the original file names to eliminate those changes. > No one has proposed changing the behavior of the -b flag (that would be silly), but rather the default behavior (sans -b flag). The -b flag is the proposed solution to maintaining the status quo across such a change if it happens.