From nobody Sun Apr 10 14:43:41 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E1CA51AA808B for ; Sun, 10 Apr 2022 14:43:54 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KbvrB5rKLz3L1D for ; Sun, 10 Apr 2022 14:43:54 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649601834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q32kha6FdoEfJv1DIv0uH+VTQFx8hhKeL1dp7YkLSlQ=; b=L2+e41dcRfKpPX4SrT/jbmL1jN6MUYKEeiCuDqj+OZA+yR9d8XUGZ/ZKyaEYopaja4U3KZ iGK8f+rDU6ycStbRdYo+9qJpCNFJ2gMkNllBORp/S4nWMvpjlHISILl0O5cZPk7HU7ahGy gVff4qORI9CiHGMrX+wd6GsL2adWbg6OM2nnMgPZ8CaqEhubkwyJU3IOzqhmF9hvUUJUJh oHMCvCQXlwXtocQfYse3VzEamYtg+WpywBay6iq2+rclZ2xYzHG/LEZHd2bGPJ83pLWEyA HtMFQddj8h7qym7ErmKxoD6ZMa+07Bm9IQjoAJsRvePohgZmWS8Nn03lLlEO8w== Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id A36892563C for ; Sun, 10 Apr 2022 14:43:54 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f175.google.com with SMTP id u19so7552987ljd.11 for ; Sun, 10 Apr 2022 07:43:54 -0700 (PDT) X-Gm-Message-State: AOAM530ZOjHw2hwkdspmD3NfX+LefydIg+XUQ0xJ51h5DDQ6j1D4KrQe OdzDKX+5iAyYGU4u+xo60e0ttUZeY4vULxJdO0g= X-Google-Smtp-Source: ABdhPJxMpKYz7UaxnKEOcfLGY1qwHMD2bLnfNPuxNh397riVkiYNOVEcA2/w4CmJ5UfHIz5O9M4duJMo1/f6J6wsEpI= X-Received: by 2002:a2e:8e96:0:b0:24a:eac4:7ffe with SMTP id z22-20020a2e8e96000000b0024aeac47ffemr17730405ljk.430.1649601833135; Sun, 10 Apr 2022 07:43:53 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Kyle Evans Date: Sun, 10 Apr 2022 09:43:41 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC] patch's default backup behavior To: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649601834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q32kha6FdoEfJv1DIv0uH+VTQFx8hhKeL1dp7YkLSlQ=; b=KYzoaMyuuEu+2DhT1Em1t1zCjzvqITKqhSrCYRtHww1VDVsVVxKEWsS8qFsqzLVBRjHDWq kVsnDEblW4tBkRqjMp81feSYcupIDhR9HSYMda0CoqG3GBolhGYIf5MMDlArkXaLTHDLHs lu24UukDzHTZ5RcTixcBO9v1OF1dTxgY6qjSKI3b9TCIgCSG0oX7o4p43VjMjA1J+41oGE dSKpwi0XDlbLSxREYFgud4flWoumbriL+blexpcDVOlHxlU2unk8sGHqD4KqCl8DCoa9Zn 35vuHEEX3B25c8ZpKc2GNNBOHhafLl22bodMIyckRBXtg4AxQOF4qCo28tAdGw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649601834; a=rsa-sha256; cv=none; b=RE/tK/bC6wZVsSB0k+oBXmgQrEuuqCn94zV0imlp87SVZRKjzk1pf+lgxRHkFC9VeSSqqt RR0Zj9eex/ANyzCh/OLeCa+SMBqUKe6JVii/7Rz57vXYekF5JFk1o2pE7/s+7N70gSF3sl qxuThip+4yc+F775vT0XJtutT6b7OnXEc40XEujr0y6WZfvCIBxXbS51aS6lyyIMnffYeY ycWKbDopmzVlXqk0MToX6/+MH89mSDcuo7PK9pjwAFcQXi9vcJrcGpa8ZfAZrf4CDvvbpU 8u88avWEoi9atTgIl19bPK+CdTIXlajL8McitZEz4Ti8FewvXPIBFU/Uh34WSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Sat, Apr 9, 2022 at 8:17 PM Joerg Sonnenberger wrote: > > Am Fri, Apr 08, 2022 at 10:25:08PM -0500 schrieb Kyle Evans: > > I'd like to test the waters on switching this to the GNU behavior, > > which feels a whole lot more reasonable. Notably, they'll only create > > backup files if a mismatch was detected (presumably this means either > > a hunk needed fuzz or a hunk outright failed). This yields far fewer > > backup files in the ideal scenario (context entirely matches), while > > still leaving backup files when it's sensible (base file changed and > > we might want to regenerate the patch). > > > > Thoughts / comments / concerns? > > Personally, I'm more often annoyed by the GNU behavior than not. > Especially when working on pkgsrc, the GNU behavior of > sometimes-not-creating-backups actually breaks tooling. I also consider > the rationale somewhat fishy as tools like sed have historically not > operated in-place. > To be clear, when you say 'tooling' here, are you referring to pkgsrc tooling or random third-party tooling being used as, e.g., build dependencies?