From nobody Sat Apr 09 03:25:08 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7C6011A906C7; Sat, 9 Apr 2022 03:25:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kb0qj338lz3Jp3; Sat, 9 Apr 2022 03:25:21 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649474721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=Y3yxpgZoxfflKs/ZkOzVqaw9vXhF5AjrPD0Z5Qzv9uQ=; b=Ovcwiiq9eZ28t5XY5l699kni+MoO7tCEi8o+eeA6iOCNpE+wENuVfDZSJ7yZ4+IFVqQq1r QyAhBoHLeDC81tCqFeP80OsLEn0UGBMDaxPUXbhS2wXmymquQRPN+XX+uPnXHp7OgVYZif 6EUxfhte3Zy8kfbhlohl1eXBQERFiy8c1rfDLln7MwmS9rJK4fC3TemhuvWSnIUkdkn3FN vOrhaYda95v6H8jD7q2a757gQCyq2EUdLd3Oimwn1EBX9XK/WJAU9l/K+/D0W4IG6ZibqE r1ys5H6e170iRW7NmUBR6veG8eXQhhFLwnwgSzTzXNJ0WOBVCG1/BihKZRalJA== Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 441CD20B9; Sat, 9 Apr 2022 03:25:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f46.google.com with SMTP id h14so12836664lfl.2; Fri, 08 Apr 2022 20:25:21 -0700 (PDT) X-Gm-Message-State: AOAM533k+6J/5u5TX/3ozgWzF+n+C4WAsJFJUNIvRtmUmoOdM2aPnOHG TF0BJ3zrVPDt4W80GhdEihkSrc8Esz53dq5hH74= X-Google-Smtp-Source: ABdhPJysOwpyBhHvkLM1vZbPZTl0uCPpZxuEyZwZdngkIYlvl9e6kt7CFeFgytu0IuaYCZeBVxVYUZ0lIKIjoFGrDgU= X-Received: by 2002:a05:6512:22d3:b0:44a:518d:c23b with SMTP id g19-20020a05651222d300b0044a518dc23bmr14598737lfu.21.1649474719782; Fri, 08 Apr 2022 20:25:19 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 From: Kyle Evans Date: Fri, 8 Apr 2022 22:25:08 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: [RFC] patch's default backup behavior To: freebsd-arch@freebsd.org Cc: FreeBSD Hackers , ports-list freebsd Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649474721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=Y3yxpgZoxfflKs/ZkOzVqaw9vXhF5AjrPD0Z5Qzv9uQ=; b=cSr6bXBo77hbjorcaszsH/yMub8iNstUTzQuLlRto/fBfzL85CtNUJy1N30CyjKzy3oPwn VlwUJz1Yq2oIE3AyHduiFv2rpXCte/EpHbw4+KIfSPTotkGrNUbdSyAIq1to4WsN2jZEGY fcwAp5jpqzm1+ryI/xuyLy8k5Lrm1OTxLn2GCLHklUVTJctj/+YMSUmJTgPpCe65AAWuAf fgI8QMKJj/ue4b4bcW9cYe9znGn80UQPt9pqXLuD+pR3ewcIzLPklgG69JKN0O2tioReHO 0JCgA2Opan8s1ecFwk3xmIfZRaa636l1rKinnNhLo92mhZfbIYDPEZS5UvoZbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649474721; a=rsa-sha256; cv=none; b=wDYoECRxRtgayJnJt8jHJrEtQp9kTTVEl27ZUXmAk+9vkPVDeErtdQWiS+0Um3yd4KYVoX bhMClXS5q48IIBCZoRanBdK/SvpiGHdMQ3majeaXx2pfAMRSMBiz1yv4VPW59nC7t2BYSZ EveAQ8WF2Pq+NW/gw+xNbFKBcEwdamHWKpMWin7VFiEiT0o2+dlJDkkwWAEmovcesEKkvA FJWQX15sJuLsO8CBzGueDIK2UUdOZO6lBDSmEK0IX02B4Rl6CMgeDg57jS7tUxWydVYmNx vxlr9NdNdWYkztbaA5sOAod/camErrnBa1AvP6oku8hvhexjvE+U9k4Enny1QA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Hello! FreeBSD's patch follows historical patch(1) behavior w.r.t. backups, where a backup is created for every file patched. I'd like to test the waters on switching this to the GNU behavior, which feels a whole lot more reasonable. Notably, they'll only create backup files if a mismatch was detected (presumably this means either a hunk needed fuzz or a hunk outright failed). This yields far fewer backup files in the ideal scenario (context entirely matches), while still leaving backup files when it's sensible (base file changed and we might want to regenerate the patch). Thoughts / comments / concerns? Cross-posted this to a couple of different lists to try and hit the largest number of stakeholders in patch(1) behavior. Thanks, Kyle Evans