From nobody Thu May 27 06:40:09 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DF984C79327 for ; Thu, 27 May 2021 06:43:56 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FrJF85sj3z4RLS; Thu, 27 May 2021 06:43:56 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-qk1-f173.google.com with SMTP id 82so3627904qki.8; Wed, 26 May 2021 23:43:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WjQnc/6LhCRDdqKQGruGKSpR/qqU2ftRb7Q/M8eXwxg=; b=jDAfid16j0BNuaHRpJBdg4w7LTu9jIQ7BDghueRwl4WKG3AtwXIR3hHjz3ubhOelwe y60T3IZD9PkZ9y5xEx35/cIR0VDn1S9EuCghckW7mot8ccwP1GwN6O18iDfEivU/sHMD 4ajup47xBYwu4GNIXSDmRm/8XODbcxNBTfCAxUgB0XMoCqaaayhzjS8d+NHttDXYPBbN Z6oBfXtoNIveU5qQSAEq6Eyip6dewuU7vifNtUw6Lhjw9kxbUz14kacOzsNqVkSlYtCp LYCA/SL8HHkPd5i6/WZv2vx+719x5dMUrXpc53k+H8i+Z2rPKbOQCbRa8LZlz4S1VbEv SbDw== X-Gm-Message-State: AOAM530BLGaZ8oqRMT07E50jQExMxx1M33u1FGM8+dp9/UfOCjUB9v2r ApsbvQ5640JLKpwfDm+cLD6P+h/I7dhiiw== X-Google-Smtp-Source: ABdhPJxPotbahz9G6Jg+xH0cgJCkm5keeabO/Db1SmkYvYCS1EAIZIrQGPV7va/Xi2xeNyeN9PI/uA== X-Received: by 2002:a05:620a:15e3:: with SMTP id p3mr1971150qkm.115.1622097835618; Wed, 26 May 2021 23:43:55 -0700 (PDT) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com. [209.85.219.180]) by smtp.gmail.com with ESMTPSA id s24sm805889qtx.94.2021.05.26.23.43.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 May 2021 23:43:55 -0700 (PDT) Received: by mail-yb1-f180.google.com with SMTP id w1so5672312ybt.1; Wed, 26 May 2021 23:43:55 -0700 (PDT) X-Received: by 2002:a25:bb41:: with SMTP id b1mr2616350ybk.249.1622097834986; Wed, 26 May 2021 23:43:54 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Thu, 27 May 2021 08:40:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Inclusion of all manual pages in all architecture releases To: Ian Lepore Cc: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4FrJF85sj3z4RLS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, May 26, 2021 at 5:23 PM Ian Lepore wrote: > > On Wed, 2021-05-26 at 17:04 +0200, Fernando Apestegu=C3=ADa wrote: > > I don't know what list this should be sent to, apologies if the > > audience is too wide. > > > > For some time now, we have not included all manual pages in every > > FreeBSD packaged release. For instance, i386 man pages are not > > included in the FreeBSD amd64 distribution. > > > > This causes a number of problems: > > > > * The https://www.freebsd.org/cgi/man.cgi is incomplete. As an > > example, it does not show results for pae(4). The reason for this is > > that the cgi interface runs on FreeBSD amd64. > > > > * In FreeBSD amd64 some manual pages have broken X-refs. See hptrr(4) > > for an example. > > > > * Also, we have broken links in our Release Notes. This is a > > consequence of the first point. See > > https://www.freebsd.org/releases/13.0R/hardware/#proc-i386. > > > > Is there a specific reason for this? > > > > Cheers. > > > > I have tried multiple times to get the people who adminster > freebsd.org's man.cgi to include all arches. I added the ability to > generate and install all of them by setting MAN_ARCH=3Dall (or to a list > of arches) on the build command line years ago. But I haven't had any > success in getting that used to install all the arches for the website > and man.cgi updated to make the arch selection list on the webpage > actually work. Hi Ian, Thanks for the explanation. That would fix the man.cgi and consequently the Release Notes issues. However, in order to fix the broken X-refs in the manual pages of the release distributions, wouldn't we need to build them with MAN_ARCH=3Dall? According to make.conf(5), MAN_ARCH defaults to MACHINE and MACHINE_ARCH. Would it be possible to change the default value to "all"? diff --git a/share/man/man4/Makefile b/share/man/man4/Makefile index f7626c80eeb1..583c4a4b9bb9 100644 --- a/share/man/man4/Makefile +++ b/share/man/man4/Makefile @@ -897,9 +897,7 @@ _cgem.4=3D cgem.4 MLINKS+=3Dcgem.4 if_cgem.4 .endif -.if empty(MAN_ARCH) -__arches=3D ${MACHINE} ${MACHINE_ARCH} ${MACHINE_CPUARCH} -.elif ${MAN_ARCH} =3D=3D "all" +.if empty(MAN_ARCH) || ${MAN_ARCH} =3D=3D "all" __arches=3D ${:!/bin/sh -c "/bin/ls -d ${.CURDIR}/man4.*"!:E} .else __arches=3D ${MAN_ARCH} This way, the released distributions will have all the man pages (we have some PRs related to this) and would also fix man.cgi regardless of the FreeBSD version the service runs on. I am assuming here that we do not explicitly set MAN_ARCH to a specific architecture when building the releases but we take the default value. Cheers. > > -- Ian > >