Re: Inclusion of all manual pages in all architecture releases

From: Fernando Apesteguía <fernape_at_freebsd.org>
Date: Thu, 10 Jun 2021 14:18:32 +0200
On Mon, May 31, 2021 at 6:17 PM Ceri Davies <ceri_at_submonkey.net> wrote:
>
> On Mon, May 31, 2021 at 12:07:22AM -0700, John-Mark Gurney wrote:
> > Fernando Apestegua wrote this message on Thu, May 27, 2021 at 08:40 +0200:
> > >
> > > Hi Ian,
> > >
> > > Thanks for the explanation. That would fix the man.cgi and
> > > consequently the Release Notes issues.
> > > However, in order to fix the broken X-refs in the manual pages of the
> > > release distributions, wouldn't we need to build them with
> > > MAN_ARCH=all?
> > > According to make.conf(5), MAN_ARCH defaults to MACHINE and
> > > MACHINE_ARCH. Would it be possible to change the default value to
> > > "all"?
> > >
> > > diff --git a/share/man/man4/Makefile b/share/man/man4/Makefile
> > > index f7626c80eeb1..583c4a4b9bb9 100644
> > > --- a/share/man/man4/Makefile
> > > +++ b/share/man/man4/Makefile
> > > _at__at_ -897,9 +897,7 _at__at_ _cgem.4=    cgem.4
> > >  MLINKS+=cgem.4 if_cgem.4
> > >  .endif
> > >
> > > -.if empty(MAN_ARCH)
> > > -__arches=      ${MACHINE} ${MACHINE_ARCH} ${MACHINE_CPUARCH}
> > > -.elif ${MAN_ARCH} == "all"
> > > +.if empty(MAN_ARCH) || ${MAN_ARCH} == "all"
> > >  __arches=      ${:!/bin/sh -c "/bin/ls -d ${.CURDIR}/man4.*"!:E}
> > >  .else
> > >  __arches=      ${MAN_ARCH}
> > >
> > > This way, the released distributions will have all the man pages (we
> > > have some PRs related to this) and would also fix man.cgi regardless
> > > of the FreeBSD version the service runs on.
> > >
> > > I am assuming here that we do not explicitly set MAN_ARCH to a
> > > specific architecture when building the releases but we take the
> > > default value.
> >
> > I would like to see this change made myself.  It'd nice to be able to
> > use your amd64 build box to be able to get information on other systems
> > by default.  The extra space is minimal.
>
> Agreed.  I would prefer if architecture specific pages went into their
> own section, and were then hardlinked into the existing architecture's
> standard sections (this would preserve current behaviour, and allow each
> architecture its own namespace if needed).

I created https://reviews.freebsd.org/D30715 and took the liberty of
adding some of you who provided feedback, to the review.

Thanks!

>
> Ceri
> --
> That must be wonderful!  I don't understand it at all.
>                                                   -- Moliere
Received on Thu Jun 10 2021 - 12:18:32 UTC

Original text of this message