From nobody Thu Jul 29 07:41:07 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D2EFE12BC256 for ; Thu, 29 Jul 2021 07:41:10 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gb2X65dsqz3Q75; Thu, 29 Jul 2021 07:41:10 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 964DEC364; Thu, 29 Jul 2021 07:41:10 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id CCFF0428E6; Thu, 29 Jul 2021 09:41:07 +0200 (CEST) Date: Thu, 29 Jul 2021 09:41:07 +0200 From: Baptiste Daroussin To: Craig Leres Cc: freebsd-hackers@freebsd.org Subject: Re: pkg/poudriere: dangling symlink to pkg.pkg.sig Message-ID: <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> References: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Tue, Jul 27, 2021 at 02:05:14PM -0700, Craig Leres wrote: > > For the last few days, approximately corresponding to when the pkg port > upgraded to 1.17.0, the poudriere build process has been creating a dangling > symlink from pkg.txz.sig to pkg.pkg.sig. Posting an issue to > github.com/freebsd/pkg did not prove useful; does anyone understand what > broke (and how to fix it)? > > I ran into this because I use a cron job to archive poudriere build trees; > the job does a diff -r of the latest pkg tree vs. the most recent archived > tree (to decide if the new tree is worth archiving). > > Craig > I told you to have a look at the commit in the ports tree in the github issue, which apparently you did not. In particular: https://cgit.freebsd.org/ports/commit/Mk/bsd.port.mk?id=ec2764d5ec4933f52cb0718663f60f1e1b1eed7f This is not done by pkg, so this is not a pkg bug, neither done by poudriere, this is done by the ports tree, this is a transition so that when someone is signing his own repo, he has valid signature for FreeBSD 12.2 and 11.4 which are the 2 systems which do not know about .pkg extention for the bootstrap of pkg. The safest way to do that was to create a dead symlink so the when pkg.pkg.sig appears the symlink is not dead anymore and bootstrap signature can be checked. 1 improvements that can be done, (I don't have time to do it right now: limit this to only be created on FreeBSD 12 and 11, limit it to cluster package building) Best regards, Bapt