From nobody Mon Jul 19 14:08:02 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DC24912AFE71 for ; Mon, 19 Jul 2021 14:08:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GT3bM5YZWz3FmW for ; Mon, 19 Jul 2021 14:08:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x836.google.com with SMTP id w26so12989217qto.9 for ; Mon, 19 Jul 2021 07:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H/DxQuck+XAf2oWlBYiMShkttjeS7dW7VsTPVYzin/E=; b=fov/7baI9BonDl0sa6DTr1hOmYEphpz/CfKwntzH/cMwtu62eagJZ8qHECPHcBFUaH pbCOtH3QnbstsOJCm9AFn2MEWqaauC5FJO17Q/KDLUljuHzXcvT0/yr0Z43osHiIcI7O JmS4WLAoa2FjwZHiBthCJ7qsOJ0nJ/guw5Ew7BB+9bgHxq8hNZ57bsYHrK/71Kh+R2pq YlrE3l2GSi6GCIs/ri/yf4exCtqnE70QhgrXSCuN5CUSgULfrPGAkwypNTm+R6ctuI79 2A/qWqWoo/ILwkeJ/IjqCDjiUO3o4tfvphdX3Q1dciexaSTAemeLpD8yTLm6P3+Gdq9p 2gtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H/DxQuck+XAf2oWlBYiMShkttjeS7dW7VsTPVYzin/E=; b=qyeRhI/bffLO+ULbNkp5GZ1YvK7bOcBc0YIOaCLRKTLGQ1ZegdEvhiIMF0bDKVbKgs 10MDO0XtILJQRCvRfLXCrPqToNVCuuIl+dv6bmLvvXhcJsSvAV66875Lw/iAgGenaRr4 p32GWIVABHnQkofLW8uykU7Ng4albSZFcg8FckediXW4g2nLpHVzpobzobqAaBd1hyuQ 5IhG+fvS1oHxC9mhMmDRTEtcWX7rH3zwIULsKzDp+NmeEuxnoTcLpkQUJ6GB6aWIO38Y Pk/hIW0nbG9tS5NgVIg3jAL0BXv9tg/sgOHW/bcTXRCBJgH/nAcfN68iEUQdCRzLIoRi 07AA== X-Gm-Message-State: AOAM531DumigCr+nKzaMoeCp45LuaA//EoYObDoKD/Q4ZD8ke5b+MUnt ABStgCarpbAaSdnZMcozELHrHACmsi3uScBVSRdbPg== X-Google-Smtp-Source: ABdhPJynv7FpOYMysey8eT2uIAvEvp/9FvrGSvNG1i73sdmOrwmHVKeElHfap8JwXIZsqGM/uQk5+5qvghvMSp2KCH0= X-Received: by 2002:ac8:7fd6:: with SMTP id b22mr20778231qtk.235.1626703694611; Mon, 19 Jul 2021 07:08:14 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Mon, 19 Jul 2021 08:08:02 -0600 Message-ID: Subject: Re: pondering pi futexes To: Konstantin Belousov Cc: Dmitry Chagin , FreeBSD Hackers Content-Type: multipart/alternative; boundary="000000000000df5ee905c77a7717" X-Rspamd-Queue-Id: 4GT3bM5YZWz3FmW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: Y --000000000000df5ee905c77a7717 Content-Type: text/plain; charset="UTF-8" On Mon, Jul 19, 2021, 3:35 AM Konstantin Belousov wrote: > On Mon, Jul 19, 2021 at 11:01:17AM +0300, Dmitry Chagin wrote: > > Hi, thanks for the reply, I mostly finished, > > the new futex impl is fully based on the umtx code, one question before > review. > > some umtx API, which is needed for futexes, inlined, like > > umtxq_busy/unbusy, umtxq_lock/unlock, umtx_pi_alloc/pi_free, etc.. > > For now I moved such API to the umtx header, but as far as I understand > > compilers are smart enough now to optimize code without suggestions. > > Maybe it's time to drop inline hint? > > > May be. It is impossible to provide a justified answer without looking > at the generated code, with/without inline. But usually yes, inline does > not make a difference for not too large static functions. > Even in header files? There I thought it was one of the few places it mattered due to semantic differences... has that changed? Warner --000000000000df5ee905c77a7717--