From nobody Mon Jul 12 02:08:00 2021
X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E501311D31DB
	for <freebsd-hackers@mlmmj.nyi.freebsd.org>; Mon, 12 Jul 2021 02:08:01 +0000 (UTC)
	(envelope-from leres@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4GNRxY67Y7z4tV4;
	Mon, 12 Jul 2021 02:08:01 +0000 (UTC)
	(envelope-from leres@freebsd.org)
Received: from ice.alameda.xse.com (unknown [IPv6:2600:1700:a570:e20:f2ad:4eff:fe09:150e])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(Client did not present a certificate)
	(Authenticated sender: leres)
	by smtp.freebsd.org (Postfix) with ESMTPSA id 742568BF6;
	Mon, 12 Jul 2021 02:08:01 +0000 (UTC)
	(envelope-from leres@freebsd.org)
Subject: Re: Did something change with sys/cpuset.h in CURRENT?
To: Sergey Kandaurov <pluknet@gmail.com>
Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org>
References: <f7c316f0-83c6-e238-c0a9-f289b7ec7757@freebsd.org>
 <CAE-mSOKQAHTXC_Ho7w3YQFPmSuPLkhFCC=48cLahU+9pO+TxRw@mail.gmail.com>
From: Craig Leres <leres@freebsd.org>
Message-ID: <4325a525-1530-a15e-8a0e-3267305ba64b@freebsd.org>
Date: Sun, 11 Jul 2021 19:08:00 -0700
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
List-Id: Technical discussions relating to FreeBSD <freebsd-hackers.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-hackers
List-Help: <mailto:freebsd-hackers+help@freebsd.org>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Subscribe: <mailto:freebsd-hackers+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-hackers+unsubscribe@freebsd.org>
Sender: owner-freebsd-hackers@freebsd.org
MIME-Version: 1.0
In-Reply-To: <CAE-mSOKQAHTXC_Ho7w3YQFPmSuPLkhFCC=48cLahU+9pO+TxRw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam: Yes
X-ThisMailContainsUnwantedMimeParts: N

On 7/11/21 3:19 PM, Sergey Kandaurov wrote:
> In zeek-4.0.3 (to which the port was recently updated from 4.0.2)
> the header inclusion order has changed; the relevant diff:
> 
>   #ifdef __FreeBSD__
>   #define OS_FREEBSD 1
> -#include <sys/param.h>
>   #include <sys/cpuset.h>
> +#include <sys/param.h>
>   #include <unistd.h>
>   #else
>   #define OS_FREEBSD 0
> 
> - sys/cpuset.h requires sys/types.h to define cpusetid_t (and friends),
> - sys/params.h includes sys/types.h
> 
>    this is documented in cpuset(2)
> 
> This works on stable versions such as FreeBSD 13.0 w/ clang 11.0.1, though.
> This is seemingly due to a header pollution fixed in llvmorg-12 import.
> Before that, sys/types were included indirectly with #include <random>:
> random -> istream -> ostream -> locale -> nl_types.h -> sys/types.h
> With llvmorg-12 import, istream / ostream are replaced with iosfwd.

Wow, you certainly wasted no time zero'ing in on the issue; thanks! I 
submitted an upstream pull request:

     https://github.com/zeek/highwayhash/pull/1

(I also ping'ed a contact to help insure the fix gets into the next 
release) and have patched security/zeek.

I feel obligated at this point to mention I'm rarely if ever 
disappointed when I post a question to freebsd-hackers.

		Craig