From nobody Sun Mar 09 02:39:22 2025 X-Original-To: go@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z9PP64PzTz5qMdD for ; Sun, 09 Mar 2025 02:39:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z9PP62PTkz3CQT for ; Sun, 09 Mar 2025 02:39:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741487962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=deIppGBUkEqQTGaCqmjMbI1psT78NOBrtOyzPzq/Z+Q=; b=vjmzKDJqqBeb2h2w066nwHXfaTPFQPgVVCOlKb2/s3I3kiGluirnr+gmDh4/bEoYbyWRl4 PmdzaZEqakIgjbQowXtJX8HwuRvJmkjhL6a35XrQsqm6hW+b4VH8DjNczAQnsiv0Fi3e+/ +Z3YDeJsehKjFpQqM433/Y2Fh7xKqB8QSASkp2q3R0fDXesZLdS/WkF67GvkUQoXquuTAp CcTcMbwGddquJ2OD7GtatkT+bVTENyXC7sw64MWcwta8/r2OrBfVyw12r/2gIVnmMNGjqR 5oKr0WEdEfYRq/OE2JJbRaGOpXKdLmBeGtvAiZ8N/krBceX4KZfWgPJvbFa0jg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741487962; a=rsa-sha256; cv=none; b=EPvMKARBjCNI2UoviCePAY7DknXL4tKsDJgv1KpjgHNHhfI5Ak9r2AU3AFhjOPKefuWg1v 1NJ0AVTpPLP6DWh9KFDvcZJzLIXHK6G6GQMeSdmVeZYQZMrvNS33VEdiBdTkv/p77NHOE0 ImrNsqdd5mK2MNUF4thPUQYzhIjJQyewL8Fj6ofVJY49w4eJahv32ggGHSSRCSobADw2gu uRR9zm74sdiGhXZrWjt2aDX+ERqngMFTBp/XDgZC9vc3Bje559nhHbk/6CWd+uflCL/K4U ZkQ+SpO2vOBuNO8lMZ1QLXBG4B6jykrQvLTL/cVofE7WK0JtTvZ9KZEHnwNw+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741487962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=deIppGBUkEqQTGaCqmjMbI1psT78NOBrtOyzPzq/Z+Q=; b=TRbzg1AlOXzXgSX/aTiipmbZVarMXIKe9Ug1xUZ/8A/Eb6OGvFUBPCEfodhVK1gk05Q+Xy I7AI+pJ0xUTA4taYOT5EAQ6oi8xHOTuqAHtw42UfGEweJ1RBBdlWkSEfm0m4a6X3zlqGXn kJDFXJK5vbeJy7WIy2xy3SfYVh36jldWnebgccjzXIki53+XVqKgacqT0HenyNjjmns8wc wNuRNh1cO2/BvFQwFSfsMcwBCnridgl1b75HnKv1l9oucvUTBAzKujYXN7VbDGDGQiAwhc hjJcR1qOYnOWtHlWK0VojR5Lm5auNP35G0NBOHF+9Y5UpR841LfoSMCbcB71ZQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z9PP61Nn1zqhj for ; Sun, 09 Mar 2025 02:39:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 5292dMHr014430 for ; Sun, 9 Mar 2025 02:39:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 5292dMpF014429 for go@FreeBSD.org; Sun, 9 Mar 2025 02:39:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: go@FreeBSD.org Subject: [Bug 285251] Mk/Uses/go.mk: Introduce GO_LDFLAGS Date: Sun, 09 Mar 2025 02:39:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: adamw@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: go@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Go language ports maintenance List-Archive: https://lists.freebsd.org/archives/freebsd-go List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-go@freebsd.org Sender: owner-freebsd-go@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D285251 --- Comment #1 from Adam Weinberger --- From `go doc link` (https://pkg.go.dev/cmd/link): -s Omit the symbol table and debug information. Implies the -w flag, which can be negated with -w=3D0. So, adding -w is unnecessary here. It should be very rare for a FreeBSD pkg to be built without -s, so I'm not sure about gating it behind empty(GO_BUILDFLAGS:M-ldflags*). What about kee= ping just the .if !defined(WITH_DEBUG)? If I need to define an -X variable, I wouldn't want debugging symbols to appear. --=20 You are receiving this mail because: You are the assignee for the bug.=