[Bug 278953] lang/go122: build fails on armv7 FreeBSD 13.3

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 13 May 2024 18:36:35 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278953

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/golang/g
                   |                            |o/issues/65601

--- Comment #2 from Robert Clausecker <fuz@FreeBSD.org> ---
Possibly related upstream issue: https://github.com/golang/go/issues/65601

However, this fix was backported to 1.22.1 and should therefore not be the
cause of our trouble.

I now realise that my previous bisection might have been bogus; it's a race
condition, so it might just have not triggered.

The bisection for when the race condition was fixed yields:

commit e4ebd13f7a6f216f7ddbaa1f2a3c97fd10bc3d23 (HEAD)
Author: Cherry Mui <cherryyz@google.com>
Date:   Fri Feb 9 14:17:18 2024 -0500

    cmd/dist,cmd/go: define assembly macros, handle GOARM value with
soft/hardfloat

    CL 525637 added GOARM_x assembly macros based on GOARM value. But
    it did not define the macro in cmd/dist, so the macro is not set
    during bootstrapping. This CL defines them.

    With CL 514907, cfg.GOARM can also take a soft/hardfloat suffix,
    like "7,hardfloat". Handle that case.

    For #65601.

    Change-Id: I60ffe7e8b623ae693d91d6e8595067a6f76565b3
    Reviewed-on: https://go-review.googlesource.com/c/go/+/562995
    Run-TryBot: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Keith Randall <khr@golang.org>
    Reviewed-by: Keith Randall <khr@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>

This commit was not backported, but is mentioned in the same issue as the
actual fix for the issue.  Perhaps we could apply it as a site patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.