From nobody Tue Apr 23 12:42:21 2024 X-Original-To: go@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VP1wb6dm3z5H9ks for ; Tue, 23 Apr 2024 12:42:23 +0000 (UTC) (envelope-from mfechner@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VP1wb69Hhz4dQP for ; Tue, 23 Apr 2024 12:42:23 +0000 (UTC) (envelope-from mfechner@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713876143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vcsaKds/pvH2jNXopuK0tyla+2bBMCcDerJ5xUpvPLw=; b=NZdudUD/N4heqtdj3rmn+rzwsSB3X3LbwVAH/PVZBcPYOmYdAWo04UsodVoqFhkmExlHXW MJAhBQ6HQdXwTffMdo1xVpGgc4dqbhP0lhoUx/LlU7PTaCFEwEnzCJIQugTWWbXwEhR75S Aj7TroP2GMkEjksMj1F5xY3+Hd8T9gdTbpnVcZ5Fa1iN/sTvYr/uPcbkCGfqMxaJHCxLSm klff7FmzCDqYuBBdCY3lygaVtwQPb9YM1wdnbhpTES5XAhBqNw9Qz5c4rohLhTV4iO6p3O 3TyyWudVDvsbo6AvNH3xnwWuOYUpUMj86qTwkE/o//eLkiJZWasikiz1Qqhf4A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713876143; a=rsa-sha256; cv=none; b=TQEe6eXA95dBtzadHNtjM+iYMh/XnZOrtfB4IVuWGiRK5HSvjIBv8jG3SfNxYr2gXuZjqY 8iJCW5+5jwng7PruDP39Pna0Q0BVHbqAK+Daupkaev0q8+6dfZNEGu02g7ZV0vSI/GCMZp xpUDV3WVqZ2uc24E8ln6+pSOmuksv1anGZxYpV9z7NzvUfDLU55qKRjNQpTWV8c5oHgyEY VXI1HkhGKWoKEIjH8d0xEURoxr4FerVeeWMk4ST7CzjxdRPOLo5BiaMUw8C0jJGnF0e3w3 7SusyGG6IckHnDSJozfbujZtJubwILbZwkxJOLKEBleF6UCEDGtdOzJ0udz/dw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713876143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vcsaKds/pvH2jNXopuK0tyla+2bBMCcDerJ5xUpvPLw=; b=qnEYiElgaiLDzVfskn8Grj9MSNvTKcKmFpu2ruGdyi5Af9NTyXehMnyKupTKF7LacjjfLK 3VJfxEQE7GHPKW5aiW9kC5MVlDbDpa8CTr+gkiBhU2SGQ05xgHJSVTWMEhFeNkcivRD4Xy BRDoBh4X91Ki0JNCPSf/xQ3heZZM4nTiDIGkfVEey+8AGYYhJryDCRuQADRIrSCALQfmzz +Rhz2/uXSqPyjzsQA2s4r40S6ICRlS506XxfdVpHNpYgsYebDUrI3UniTxYAjhAdap0WqA Ajf2FiaDgZDNnEYFqrepd1weu2Hm61NAntE7bmidbAwz4RWc/ElIo8i+JH/c2A== Received: from [192.168.0.151] (unknown [212.108.150.210]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mfechner) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VP1wb38w2zZ4N for ; Tue, 23 Apr 2024 12:42:23 +0000 (UTC) (envelope-from mfechner@freebsd.org) Message-ID: <0d288a87-e37c-45df-a789-97c1e6926300@freebsd.org> Date: Tue, 23 Apr 2024 15:42:21 +0300 List-Id: Go language ports maintenance List-Archive: https://lists.freebsd.org/archives/freebsd-go List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-go@freebsd.org Sender: owner-freebsd-go@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: go@freebsd.org From: Matthias Fechner Subject: Maybe modifications with newer go version in go-post-fetch required Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear all, I just had a nasty bug, that `go mod download` was rewriting the go.mod file and was adding modification to the go.mod file: > ❯ diff -u go.mod.orig go.mod > --- go.mod.orig 2024-04-21 20:01:29.098380000 +0300 > +++ go.mod      2024-04-21 21:01:03.081898000 +0300 > @@ -1,6 +1,8 @@ >  module gitlab.com/gitlab-org/gitlab-shell/v14 > > -go 1.20 > +go 1.21 > + > +toolchain go1.22.2 > >  require ( >         github.com/charmbracelet/git-lfs-transfer > v0.1.1-0.20240402115927-f0b226fa61cc This causes an invalid checksum, if you execute `make makesum` for a go package and therefor a fetch on another computer or after you deleted the go.mod from distfiles. I saw this problem for devel/gitlab-shell and fixed the problem by copy the initial go.mod and restore it after `go mod download` was executed. Maybe this is a new behaviour with go 1.22 and also a modification is maybe here required: https://cgit.freebsd.org/ports/tree/Mk/Uses/go.mk#n188 The fix I did is here: https://cgit.freebsd.org/ports/commit/?id=30ee39816e4e27529f1f2421820962b961c5fc0e Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook