From nobody Fri May 23 22:36:46 2025 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b40Q72g4Xz5wh7D for ; Fri, 23 May 2025 22:36:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b40Q64Kjwz3hxQ for ; Fri, 23 May 2025 22:36:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748039806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UNqz7mJbRochIQZbqB8sIMnzkKbCNv3MsK0+OwmrvAg=; b=miVBJeZ29ljSnsdL/H/AXzrqeauxCauo2+l6a9FhI1B9k/x0xSrqnOu/6o/zZctK2ZaGBy uFYNg4LlpYTNOg8O2JP4uMP/LksN2tr6jscXM1vLFhrhLn2Lr32hIVnJ+Szt1CUDEr8r02 wezmKhBaCYkBCnG2rxV5EcdYsr5jO+b7RlnQBAJUKbOfPmt1J9+j8brusXg8yZ64bQJeac cfwsxgLxi3ejHnB706JlgbTb+i0B03aYaUjW0jx5kww8UDllSD3SqpB2U3lqrGAaDNW7MP USgyYe3fLdpJpGhRZeKPNTVKW7LOn9RDxex3QRGqr17mx1y5b/aikx4Lz/rQ1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748039806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UNqz7mJbRochIQZbqB8sIMnzkKbCNv3MsK0+OwmrvAg=; b=k2+52XNM7Zaw/AZTP3aRBTOikq8yPAFcTnVvFhtLYbb6QirXUX6zJ0wRbdchOcfN9RKz+7 IFU+nnBv8IO58tlgOqUSLwk1YrjxzNQg3WCd89dC14ENVRhQEiAoss/MyuY99GOc+mKewD C2ad7/PryFPumETb7uqe/W+b50V03sRf6yIPqIu7t4a6ePRPCe78fcquhLSgrU6IX/w2+I 5aByDtOY03ZpRtMq8Il2aCEsdDn7SW7BR5/FDJ4cjgOwQOzrgX+9AeTehkppZtbPiabtkD RXjJQcQT30QNJhi3+j/NJB7QASEkC68UIwovAcSr+fRzLK24hIzfS8psBSb4cQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748039806; a=rsa-sha256; cv=none; b=fBw9QFsNx/YyEn8jE78J2xxlXG4Kik18TtwE+Q225wmuUd+7QRFQsb3nNcvk4n6YsVEx1Z eVaNuXMZNJA4pkbSJa5J2SxKNcsxcsutIFEF5wLY/e42QpmCAfFNGpo/NUOvwyjXul1db4 7Ab1XxSAah4PTCZkgEY4L4HunNi0b9IhaPqg/XUmGmwoy6U2CtgDr7v+UJC2VSp1AHcRu6 MUdtj4u/fxxtNxFWkuasMck5kY4dwRuZ0gJjLvJ0/qLCCAp5W1OVoCs3iXgWATu4OG3lRw 7JUWDanNnZaaaO7ZQQ5ETQMK1vMRrxBbwojlwavKOLqKQo9x1Sx3k/dApyrtaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b40Q63SLTz1NK6 for ; Fri, 23 May 2025 22:36:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 54NMakDC051088 for ; Fri, 23 May 2025 22:36:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 54NMakN0051087 for gnome@FreeBSD.org; Fri, 23 May 2025 22:36:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 286439] textproc/libxml2 local port patch causes random x11/mate-terminal build failures Date: Fri, 23 May 2025 22:36:46 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: des@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: desktop@FreeBSD.org X-Bugzilla-Flags: merge-quarterly? X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D286439 Dag-Erling Sm=C3=B8rgrav changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |des@FreeBSD.org --- Comment #13 from Dag-Erling Sm=C3=B8rgrav --- Created attachment 260665 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D260665&action= =3Dedit proper fix for UTF-8 bug The reason the patch currently causes py-libxml to crash is that it was mismerged when libxml was upgraded to 2.11.6. The =E2=80=9Censure the erro= r string doesn't start at UTF8 continuation=E2=80=9D bit was supposed to happen afte= r the `vsnprintf()` call. For unexplained reasons, it was moved to _before_ that call where, as others have pointed out, it operates on uninitialized data. However, this patch was never the correct fix. The bug occurs when `str` is too small for the message and the message is truncated in the middle of a U= TF-8 sequence, so you need to trim the _end_ of `str`, but what the patch does is skip any partial UTF-8 sequences that occur at the _beginning_ of `str`, wh= ich I'm not sure is even possible unless the format string or some of the argum= ents passed to the handler are malformed. If you don't want to reintroduce the original bug, I suggest you use the attached patch instead of just dropping patch-python_libxml.c. --=20 You are receiving this mail because: You are on the CC list for the bug.=