[Bug 257255] graphics/rawtherapee: Crashes in rtengine::Color::rgb2lab01 when editing a picture; nullptr dereference related to color profile

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 23 Feb 2024 17:37:32 UTC

--- Comment #32 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:


commit 7e027ece12342fab2bd29ce325c4a6109677ae8a
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2024-02-20 23:24:23 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2024-02-23 17:37:09 +0000

    graphics/rawtherapee: update to 5.10

    ChangeLog:      https://rawtherapee.com/downloads/5.10/#new-features

    We need to stick to GCC because LLVM-compiled code may take more than
    twice as much processing time as GCC-compiled does, for my test set
    comparing a few images with denoising and stuff on FreeBSD-14.0-RELEASE
    amd64 comparing GCC 12.3 to clang 16.0, and similar values on

    Pin GCC to 12 and override -stdlib accordingly, to fix
    PR:             273682

    Clean up Makefile a bit, but we cannot let go of the CCACHE
    workarounds yet, which we need when enforcing GCC compile.
    Convert some .if branches to options helpers.

    Make LTO an option that defaults to on. For some strange reason,
    massively-parallel compilation WITHOUT LTO appears to trigger
    OOM kills much more than an LTO-enabled build.  Upstream states
    that LTO build should run faster.

    For one self-test that fails frequently with SIGPIPE (Exit code 141 is
    128 for core dump + 13 for SIGPIPE), pipe through dd with bigger input
    buffer to avoid SIGPIPE/exit code 141 test failures.

    Replace echo by ${ECHO_CMD} in self-tests to appease portlint.
    Portlint misdetects "file system" as bare use of file though and
    suggests ${FILE}, which is wrong.

    Revise warnings around the CCACHE hacks because
    strives to move ports to CCACHE_ENABLED, which does not work for this

    Also, 5.10 should fix the profile/locale related crash
    PR:             257255
    by switching the std::map variable to use std::string as index,
    rather than Glib::ustring, which caused inconsistencies with locales.
    Upstream references (two bug reports, and the fix, in order):

 graphics/rawtherapee/Makefile  | 88 +++++++++++++++++++++---------------------
 graphics/rawtherapee/distinfo  |  6 +--
 graphics/rawtherapee/pkg-plist | 20 ++++++++++
 3 files changed, 68 insertions(+), 46 deletions(-)

You are receiving this mail because:
You are on the CC list for the bug.