[Bug 267393] net-im/libnice: Add GNUTLS option

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 27 Oct 2022 22:33:57 UTC

--- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> ---
Thank you for the patch Jonathan. Some review items:

 1) The build should be tested in these cases:

   - GNUTLS=OFF and
        - gnutls (only) is installed (not via *_DEPENDS)
        - openssl (only) is installed (not via *_DEPENDS)
        - gnutls (and) openssl are installed (not via *_DEPENDS)

 2) Consider An SSL library group with two mutually exclusive options, one

Note:  This can either be in the form of

 - OPTIONS_SINGLE (one choice *must* be selected)
 - OPTIONS_RADIO (none or one choice can be selected)

If libnice supports a build configuration without ssl library support at all,
OPTIONS_RADIO is more appropriate. If not, OPTIONS_SINGLE is the way to go

 3) The current port Makefile doesn't set USES=ssl. In the case where
GNUTLS=OFF, or the grouped option OPENSSL is selected, it should probably use
USES=ssl[:...] with appropriate variables from that file.

You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.