From nobody Fri May 28 03:25:07 2021 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1E4A6BFD34A; Fri, 28 May 2021 03:25:15 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FrqnR04pLz3kys; Fri, 28 May 2021 03:25:14 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pl1-x62e.google.com with SMTP id u7so977804plq.4; Thu, 27 May 2021 20:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MwBkvZktbRs8nMIk5masUXwW5MIsJ5j08SU+a3E86Mw=; b=tysUW3FxUwZxKLrLrTwW+9oxhXD+3K2u/SSvQkT7Bx9QdX2H4cPzJGU5s7QfvVyUZn Wt2vNoGns2BhJ1tUSiXkMBp9qYVitRUdRTyPIwja7nb3WwSApgsKrAOOPcB0a9ede0YB 3RvtUGqf5W2lTRWFt3ZQ3V7thAf8SLU6CjaVJOBIgusKXYucQtByVpb6U9Wd1sFKQEmF ub7P4EMRRodjpavvNIlf8jnDsu77dmDjf5LfdixEcLG81pZLAqXlGmbHkpV/vsiZG+kx FPJcbK/7/2uwiBKHR9sEm5XXvEGAVQKtSxqPu1sF2/tLmzKoSvN5RiWyHcIMTlcY9g5x Jp8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MwBkvZktbRs8nMIk5masUXwW5MIsJ5j08SU+a3E86Mw=; b=cGi+F6oUZp3sj8gwGGMhnSoy6MNB7xW+P5KsxPHvr2mCZ3rWyf2WHOZx59SiEOaUtc xsNLsZpSxKlNvJc5Z+uXsPT1ksw/HP2O3ZgS38y5O4qD9Vq+nBw68rpL0m4If+IL27PJ +pCNsUy1YGN6iMgSSiCEyeGOzpX892lnBwYVfX8mGasZB/t9uEuFRBpJNY63LLWjJUDw iOB2IokRbJr1Ag0mZHg+TnG1FBuQfKPwNoQZgdc5/YbUYia+q1CmmRZimrTZ6Wml4FPG t/xuG281/ka/ARqYLbY0r/otcmrpCuag0nEW8UECoNup9NspqSWzvQboDcBGDdKEcT52 Mv9g== X-Gm-Message-State: AOAM533mzWw43TShJ5TTRKjhp8AMsXJyHN4iuWhR+nwSDLfJzQvk2cr9 HfFhEcMoyrsUxlw7f9Brc2milbv5FBfefg== X-Google-Smtp-Source: ABdhPJyBKHGOkQ1J+j3afI5IiQk2v4rdUvfuZW6hgY0vNZhHi1FTlcke79jJ/IK1jrRSvQ7C4OScfA== X-Received: by 2002:a17:90a:9913:: with SMTP id b19mr1186517pjp.105.1622172312755; Thu, 27 May 2021 20:25:12 -0700 (PDT) Received: from ?IPV6:2403:5800:7500:3601:edc1:5fd6:5a0a:6c7d? (2403-5800-7500-3601-edc1-5fd6-5a0a-6c7d.ip6.aussiebb.net. [2403:5800:7500:3601:edc1:5fd6:5a0a:6c7d]) by smtp.gmail.com with UTF8SMTPSA id h13sm3168768pfr.216.2021.05.27.20.25.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 20:25:12 -0700 (PDT) Message-ID: <303b9900-d008-78a7-b3bf-ffb33284a4ee@FreeBSD.org> Date: Fri, 28 May 2021 13:25:07 +1000 List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Thunderbird/90.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: An apology about my commits Content-Language: en-US To: Neel Chauhan , ports-committers@FreeBSD.org, freebsd-ports@freebsd.org Cc: portmgr@freebsd.org, gnome@freebsd.org, desktop@freebsd.org References: <600673282f5cd5864a67655c4e156f26@freebsd.org> From: Kubilay Kocak In-Reply-To: <600673282f5cd5864a67655c4e156f26@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FrqnR04pLz3kys X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 28/05/2021 1:19 pm, Neel Chauhan wrote: > Hi freebsd-ports@, ports-committers@, > > I hope all is well with you. > > You may know I have prematurely made Ports commits without review, > namely 507359c509389602b4060b2c5e203c99911c3578 and > 0bc7478682b2d7c9393f2dd095d99072070a2f65. > > I'm really sorry if I pushed these commits without approval. > > I feel extremely guilty for making these commits without approval, and > almost felt I will lose my commit bit. I even thought at times that I > will have to switch my PCs/servers to Windows or Linux if all goes wrong > since I will feel shame for even **using** FreeBSD [1]. > > Next time, I will try not to bypass review, especially for big commits > that touch major packages like devel/glib20. > > However, to unbreak the fetching for GNOME Ports that have been updated > to 40.x, we will need to make one change to Mk/bsd.sites.mk. This patch > is in https://reviews.freebsd.org/D30514 . This may need portmgr > approval, but I won't commit it without approval. > > Happy hacking! > > -Neel Chauhan (nc@) > > Footnotes: > > [1] - For reference, I work at Microsoft and use Windows at work, but > used FreeBSD almost exclusively at home since 2012, back when I was only > 15 (I'm 24 now), and more-or-less the only server OS I have run my home > servers on since I set that up in 2013. It's your thoughts and care that count Neel, don't feel guilty. The responses you received could have been a bit more 'matter of fact'. What was *actually* important about the replies was 'we should be QA'ing everything and getting more than one persons eyes on things'. Note (for everyone), some of the biggest impacts are caused by the smallest commits. The idea of a 'trivial update' needs to be related to the dustbin, and we're still hearing it often.