[Bug 257493] games/gnome-mahjongg: 'stage' tries to install directly to LOCALBASE

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 30 Jul 2021 21:58:46 UTC

John Hein <jcfyecrayz@liamekaens.com> changed:

           What    |Removed                     |Added
 Attachment #226809|                            |maintainer-approval?(tcbern
              Flags|                            |er@freebsd.org)

--- Comment #7 from John Hein <jcfyecrayz@liamekaens.com> ---
Created attachment 226809
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=226809&action=edit
[patch] games/gnome-mahjongg - fix 'stage' writing to LOCALBASE

This patch disables the attempt to run glib-compile-schemas and
gtk-update-icon-cache during 'make stage'.  Both of these were trying to write
to LOCALBASE instead of the staging dir (work/stage) which triggered a
'permission denied' issue if running 'make stage' as a regular user.  And both
are already done anyway by the gnome ports infrastructure at 'install' time (or
if installing from pkg, at the time the of the 'pkg install').

There is also a change in ordering in the Makefile for the USES line (prodded
by portlint's whine).

There is no need to bump the PORTREVISION - there is no change in the package.

I tested in poudriere (testport -i to get interactive mode) by creating a
regular user and doing 'make clean stage' as the regular user.  Without the
patch it fails (as expected) - with the patch it passes 'make stage stage-qa
check-plist' as the regular user and 'make install' as root.

 - portlint: ok (1 less warning after patch)
 - testport: ok (11-stable/amd64)

You are receiving this mail because:
You are the assignee for the bug.